You are viewing a single comment's thread from:
RE: [Steem Curator] - User Preference Settings
Thank you for your contribution. A nice update to the project. Few thoughts -
- +1 for adding the tests.
- It's better not to hardcode username
- +1 for using ES6 features.
Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.
To view those questions and the relevant answers related to your post, click here.
Need help? Write a ticket on https://support.utopian.io/.
Chat with us on Discord.
[utopian-moderator]
Thanks for the review. I cant find username hardcoding. Can you point me to that.
Its line number 18 of src/app/utopian/reducers/utopian.reducers.ts
Got it. That was in the first commit when i hadn't built the load feature. It was removed in next commit.
Ok cool, I might have missed that :)
Thank you for your review, @codingdefined!
So far this week you've reviewed 1 contributions. Keep up the good work!