You are viewing a single comment's thread from:

RE: Projecteer Update : Dashboard design, User Joins Team and Other Additions

in #utopian-io5 years ago

Thank you for your contribution. A lot of work has been done in this contribution, and the post is of very high quality. Few thoughts about the code :

  1. If possible do not try to use !important in CSS, it will make a problem later.
  2. In the client/src/app/dash-view/dash-view.component.ts component, I can see you have subscribe to a lot of observables in ngOnInit, it would be better to unsubscribe too in ngOnDestroy otherwise there will be a memory leak.
  3. I don't think so you required isNotTeamLead variable when you have isTeamLead, you can set isTeamLead to true or false based on if the current user is team lead or not.
  4. I can see a lot of console.log for logging, try to use better loggin mechanism.

If you need any clarification about the given score, please ask.


Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.

To view those questions and the relevant answers related to your post, click here.


Need help? Chat with us on Discord.

[utopian-moderator]

Sort:  

Thank you for your review, @codingdefined! Keep up the good work!

Coin Marketplace

STEEM 0.17
TRX 0.13
JST 0.027
BTC 60777.85
ETH 2609.63
USDT 1.00
SBD 2.65