You are viewing a single comment's thread from:

RE: EduSteem - Student interface (Dashboard)

in #utopian-io7 years ago

Thank you for your contribution.

Few points :

  1. https://github.com/bflanagin/EduSteem/commit/e9303468393f9d21545bd335d8df61e0a65020d1#diff-194fc0b3949bb26afd4dfa9303c3cf29R315, since you have one one switch case you can use if.

  2. You are using time.toString().split(".") quite a lot of time, instead use once and copy that to a variable and then use that variable to get the splitted values. https://github.com/bflanagin/EduSteem/commit/e9303468393f9d21545bd335d8df61e0a65020d1#diff-ea6e8a9b7a2f565df5322a79298f8b17R501

  3. Somewhere you are using double equals and somewhere triple, its better to be consistent. https://github.com/bflanagin/EduSteem/commit/e9303468393f9d21545bd335d8df61e0a65020d1#diff-ea6e8a9b7a2f565df5322a79298f8b17R559

Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.

To view those questions and the relevant answers related to your post, click here.


Need help? Write a ticket on https://support.utopian.io/.
Chat with us on Discord.
[utopian-moderator]

Sort:  

Hey @codingdefined
Here's a tip for your valuable feedback! @Utopian-io loves and incentivises informative comments.

Contributing on Utopian
Learn how to contribute on our website.

Want to chat? Join us on Discord https://discord.gg/h52nFrV.

Vote for Utopian Witness!

Coin Marketplace

STEEM 0.09
TRX 0.31
JST 0.030
BTC 109987.17
ETH 3726.01
USDT 1.00
SBD 0.62