You are viewing a single comment's thread from:

RE: Added users page, function to delete user and function to count number of location inserted by user

in #utopian-io5 years ago

Thank you for your contribution. A nice update to the project. Few thoughts about the contribution:

  1. It is not a good way to expose your token, I am not sure if it's a cookie token - https://github.com/sogatanco/nebeng/compare/master@%7B06-20-19%7D...master#diff-cbae000e427c87a63c8e10fff08a0fd3R73
  2. I can see a lot of code has been duplicated in a lot of files, you should try to create one function and use it everywhere i.e. DRY approach.

Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.

To view those questions and the relevant answers related to your post, click here.


Need help? Chat with us on Discord.

[utopian-moderator]

Sort:  

Thank for reviewed. That is a public token so I directly put it on code. btw thank for your advice, I will try to make the code shorter

Thank you for your review, @codingdefined! Keep up the good work!

Coin Marketplace

STEEM 0.22
TRX 0.20
JST 0.035
BTC 90822.08
ETH 3148.18
USDT 1.00
SBD 3.11