DTube App for Android & iOS

in #utopian-io4 years ago (edited)

Repository

https://github.com/bostrot/DTubeViewer

  • What is the project about?
    This is a native Android & iOS app developed for d.tube the ipfs/blockchain video streaming platform. It is built with flutter and is highly customizable. Currently it supports basic functionality like video streaming, reading and commenting on posts as well as the picture-in-picture mode on both iOS tablets and all Android devices above SDK 24. Adding to that it supports a smooth video experience on-the-go with listing all followed videos and categorizing them. Included is a nice download manager that let you list all your downloaded videos. It also supports opening the videos in external apps for e.g. chromecast streaming until it is available in the app itself.

  • Technology Stack
    flutter
    dart
    libs

  • Features
    Download manager
    Smooth experience
    Basic commenting, voting with custom power
    A reliable search
    Tag search
    Multiple themes and two designs
    Viewing your voting power
    and some more

  • Roadmap
    Notifications on new videos from followed authors
    Materialize UI
    Adding Chromecast/DLNA and AirPlay
    Customizable themes
    Add DTalk
    Video to MP3

  • How to contribute?
    I am highly active on GitHub were you are free to submit any pull requests and issues for feature requests, suggestions and bug reports.

GitHub Account

https://github.com/bostrot

Sort:  

Thanks for the contribution, @bostrot. As @reazuliqbal has already mentioned some things to keep in mind here and I have already left a comment here I won't go over the same things again in this comment.

Instead I will focus on reviewing this commit, which is what I'll base your score off of. For future reference it would've been better if the development contribution covered and explained the feature(s) added in the above commit instead of the entire project (for project introductions you can use the blog category instead).

Anyway, let's have a look shall we?

  • I'm not familiar with Dart and since there are no comments it's not really clear to me where the magic numbers in this come from. Wouldn't it be better to use constants declared somewhere else for this?
  • The amount of characters per line is pretty high in some places. Not sure if there aren't some best practices to keep the line width below a certain number, but I think it would definitely improve the readability of the code (had to scroll horizontally in some places).
  • There aren't really that many comments (function declarations would be nice at least) and there is quite a lot of commented out code left in there. In my opinion it would be better to remove those unused snippets, but if you might need them in the future then I understand.

Other than that everything seems to look fine to me and I don't have any other remarks - great work! I will once again (it's that good) recommend you read this amazing guide on how to achieve a higher score in the development category before creating another contribution, as it will definitely help you receive a higher reward (it's exponential and not linear).

Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.

To view those questions and the relevant answers related to your post, click here.


Need help? Write a ticket on https://support.utopian.io/.
Chat with us on Discord.
[utopian-moderator]

Thank you for your review, @amosbastian!

So far this week you've reviewed 3 contributions. Keep up the good work!

Well thank you again for this detailed anwer. I will add more comment in the future. The magic numbers you mentioned is a function that returns an Array (in Dart: list) of possible video qualities. This happens with checking whether the desired quality exists in json_metadata.
Wrapping lines can be done, though Dart especially Flutter is known for those heavy indents. But its true I could have avoided a few of these.
Some of the unused parts are important and some not. Will sort this out.

Hi @bostrot, nice project though I have not checked the app.

A few tips for your next contributions:

  • @utopian-io recommends you make small multiple commits which makes it easier for a moderator to check and understand your code easily. Your most recent and important commit is a very large one.

  • Your most other commits are more than 14 days old though they are planning to increase the commit max age to 28 days but you can use Pull Request and Merge to get over this. Here is a reference.

A good project nonetheless. :)

Hey @reazuliqbal
Here's a tip for your valuable feedback! @Utopian-io loves and incentivises informative comments.

Contributing on Utopian
Learn how to contribute on our website.

Want to chat? Join us on Discord https://discord.gg/h52nFrV.

Vote for Utopian Witness!

Hi, thank you for the information. I didn't expect that and will (hopefully) do better in future :)

Hey @bostrot
Thanks for contributing on Utopian.
We’re already looking forward to your next contribution!

Want to chat? Join us on Discord https://discord.gg/h52nFrV.

Vote for Utopian Witness!

Hi @bostrot! We are @steem-ua, a new Steem dApp, computing UserAuthority for all accounts on Steem. We are currently in test modus upvoting quality Utopian-io contributions! Nice work!

I can’t get that app to work at all!

Posted using Partiko iOS

Coin Marketplace

STEEM 0.26
TRX 0.08
JST 0.044
BTC 29752.38
ETH 1957.88
USDT 1.00
SBD 2.64