[busy][2.5.6] reblogged-by information is not shown in feeds
Project Information
- Repository: https://github.com/busyorg/busy
- Project Name: Busy
I reported the issue and made a pull request.
Expected behavior
Reblogged post in feed should be shown as "reblogged_by {username}"
Actual behavior
Reblogged post in feed is shown the same way as other posts of followings. Thus, it's impossible to know if a post is one of my followings or one of followings of my followings, which is very annoying.
How to reproduce
- Prepare 3 users: A, B, and C.
- Log in with A and follows B but not C.
- Make B reblog C's post.
- Then C's post is shown in A's feed without "reblogged_by."
- Browser version: Any
- App version: Busy 2.5.6 (current)
- Operating system: Any
Recording Of The Bug
Busy.org: my feed (rosatravels isn't my following)
Steemit.com shows the reblogged information correctly
Cause and Fix
Busy.org uses post.first_reblogged_by which is always null. post.reblogged_by should be used, as in steemit.com https://github.com/steemit/condenser/blob/7430aca58ae9f86e501f52e3cf8dba5efc9fe3e0/src/app/components/cards/PostSummary.jsx#L70
I made the fix and PR. Here is the screenshot after the fix on my local dev server.
After the fix on my local dev server
GitHub Account
https://github.com/economicstudio
ps. I know that I can get bonus point if the PR is already merged. I'm pretty confident with my code, but as you can see, busy team is not so active these days, so I've decided not to wait for merging, which may take too long. Hope busy team will be active again. Thanks.
Hi @blockchainstudio, thanks for making this contribution.
I observed the same behavior. There's no way to tell whether the post on your busy feed is by a user you follow, or if it's just a reblog from a user in your following list of a user in their list. This constitutes a strange user experience.
I appreciate that you have provided a fix. You still get a score for it, the questionaire accomodates cases like this. Only issue here is - since it has not been merged we cannot tell if the PO found it suitable. This is reflected in my scoring :)
The steps you provided were easy to follow. I understand using three accounts simplifies the process. But in a way, you can reproduce with a single account - that's assuming you know everybody you are following and you are also able to tell a strange post from an unknown username. Much tougher, I must agree the steps you provided were much better :D
Thanks again for the contribution. We look forward to your future reports :)
Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.
To view those questions and the relevant answers related to your post, click here.
Need help? Chat with us on Discord.
[utopian-moderator]
Hi @fego, thank you for your review. As I wrote in "p.s." in the post, I know that I can get a higher score if it's merged, but I kind-of gave up waiting for busy's response. If you go to busy git hub, there are 5 PRs of mine :) Thanks again!
Thank you for your review, @fego! Keep up the good work!
Summary in Korean: 어쩐지 busy에서 제가 팔로우하지 않은 듯한 사람이 feed에 종종 보이더라니 이게 버그였습니다. "reblogged by 누구"하고 스팀잇에서 처럼 보여줘야하는데 busy가 언젠가부터 스팀잇 API변경으로 이게 정상동작하고 있지 않았습니다. 제가 불편해서 고쳐놓긴 했는데 솔직히 busy가 이제 좀 실망스러울 정도로 일을 안해서(혹시나 자기네 문제 생길 것 같은건 고쳐뒀더군요. 그래서 더 괘씸ㅎㅎ) merge에 대한 기대 없이 그냥 submit합니다.
ps. 깃허브에도 써놨지만 feed가 아닌 blog에서 resteem한 것도 표시가 안되어있는데 로직상 블로그인지 feed인지를 구분하지 않게 해놔서 고치는게 아주 간단하지는 않고 blog는 리스팀구분이 그래도 해당 블로그 저자가 아니면 바로 구분되니 그나마 괜찮은 것 같아 추가로 시간들여 거기까지 고치진 않았습니다. 관심있으신 분은 직접 고쳐보세요^^
비지가 조금씩 업데이트 되는 것 같아서 기분이 좋네요. 저번에 수정한 코드까지 포함해서 빨리 반영되었으면 좋겠습니다.
감사합니다^^ 꼭 필요한 것빼곤 일을 안하는 듯하여 10개 정도 PR이 쌓이면 제가 서버를 띄우는게 빠를듯해요ㅎㅎ
ps. 보니까 댓글 버그도 있는 것 같네요. 원래는 댓글 쓰면 바로 새 댓글이 refresh되어 보이지 않았나요? 현재 안되는듯.
댓글을 새로 등록하면 댓글 리플래쉬가 자동으로 되었는지는 잘모르겠어요. 아무래도 버그인가봐요. 이것도 버그 헌팅으로 포스팅 하세요. ㅋ
그리고 다른 스팀잇댑을 다 사용해봐도 busy가 가장 맘에 듭니다. 블록체인스튜디로님 덕분도 있구요.ㅋ busy가 안드로이드앱으로도 나오면 좋겠어요.
이건 고칠줄은 모르겠어서 안쓰려다 원인은 최소한 발견해서 좀전에 리포트했습니다^^ 모바일용으로는 직접 만들어주시길 기대할게요ㅎㅎ 스팀시세만 좀 높으면 beneficiary로 좀 받아가시면서 개발할 인센티브가 있을텐데 아쉽네요ㅠㅠ
스팀 시세가 많이 떨어져서 아쉽네요. 만약 앱을 만든다면 beneficiary 보다는 임대 받아서 큐레이션으로 수익을 내고, 그 수익을 다시 사용자에게 돌려줄껍니다. ㅎㅎ
만약에 앱을 만든다면 이런 기능을 넣고 싶어요.
넷플리스처럼 작가&글 자동 추천 시스템.(알파고AI 탑재)캐시슬라이드처럼 광고 보면 스팀으로 보상.캐시워커처럼 운동량(걸음수) 만큼 스팀으로 보상.인스타그램처럼 개인 라이브 방송 가능.곰돌이가 @anpigon님의 소중한 댓글에 $0.016을 보팅해서 $0.007을 살려드리고 가요. 곰돌이가 지금까지 총 2627번 $32.516을 보팅해서 $32.588을 구했습니다. @gomdory 곰도뤼~
곰돌이가 @anpigon님의 소중한 댓글에 $0.020을 보팅해서 $0.003을 살려드리고 가요. 곰돌이가 지금까지 총 2626번 $32.500을 보팅해서 $32.581을 구했습니다. @gomdory 곰도뤼~
비지는 개선에 더욱 더 비지해져야 합니드앙~♩♬
Posted using Partiko Android
You seem more busy than the "busy" side. You are the true bug hunter. :)
You're telling me :) Thanks!
Hi @ekitcho I should receive salary from busy, or full vote everyday :) @sekhmet Please review and merge my PRs (now 5 pending).
곰돌이가 @lostmine27님의 소중한 댓글에 $0.020을 보팅해서 $0.003을 살려드리고 가요. 곰돌이가 지금까지 총 2625번 $32.480을 보팅해서 $32.578을 구했습니다. @gomdory 곰도뤼~
짱짱맨 호출에 응답하여 보팅하였습니다.
Hi @blockchainstudio!
Your post was upvoted by @steem-ua, new Steem dApp, using UserAuthority for algorithmic post curation!
Your post is eligible for our upvote, thanks to our collaboration with @utopian-io!
Feel free to join our @steem-ua Discord server
Hey, @blockchainstudio!
Thanks for contributing on Utopian.
We’re already looking forward to your next contribution!
Get higher incentives and support Utopian.io!
Simply set @utopian.pay as a 5% (or higher) payout beneficiary on your contribution post (via SteemPlus or Steeditor).
Want to chat? Join us on Discord https://discord.gg/h52nFrV.
Vote for Utopian Witness!
Thank you! This is a reply test.
@blockchainstudio You have received a 100% upvote from @intro.bot because this post did not use any bidbots and you have not used bidbots in the last 30 days!
Upvoting this comment will help keep this service running.