[busy] Multiple links in one sentence
Project Information
- Repository: https://github.com/busyorg/busy
- Project Name: Busy
I've reported the issue, made the fix, and submitted the PR.
Expected behavior
Multiple hyperlinks in one sentence should be shown as hyperlinks.
Actual behavior
Only the first link is shown as a hyperlink. For instance, https://busy.org, http://steemit.com, https://steempeak.com.
How to reproduce
- Type at least two links in one sentence. While I already provided an example in this post, if you need more realistic example, visit https://busy.org/@blockchainstudio/steem-keychain-should-hide-private-keys-by-default, for instance.
- Check whether all links are shown as hyperlinks.
Recording Of The Bug
https://busy.org/@blockchainstudio/steem-keychain-should-hide-private-keys-by-default
Compare this with the result on steemit.com
https://steemit.com/utopian-io/@blockchainstudio/steem-keychain-should-hide-private-keys-by-default
- Browser: Any
- Operating system: Any
Cause and Fix
The problem is due to the wrong html paring module. The only first link was handled by the previous code. I've changed it based on Steemit condenser code for compatibility. After the fix, it works well as follows:
Before
Visit https://busy.org/@blockchainstudio/steem-keychain-should-hide-private-keys-by-default
Hi @blockchainstudio, thanks submitting this report.
I was able to observe the behavior you have described. The links you provided in this post are rendered in a hyperlink when opened on the steemit frontend but on busy.org only the first link is hyperlinked.
I see you have fixed this in a PR. Hoping it gets approved and merged by a PO.
I would have loved you to throw more light on how you went about the fix. In all it's a great post, and a great find.
Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.
To view those questions and the relevant answers related to your post, click here.
Need help? Chat with us on Discord.
[utopian-moderator]
Thank you for your review, @fego! Keep up the good work!
Hi @blockchainstudio, thanks submitting this report.
I was able to observe the behavior you have described. The links you provided in this post are rendered in a hyperlink when opened on the steemit frontend but on busy.org only the first link is hyperlinked.
I see you have fixed this in a PR. Hoping it gets approved and merged by a PO.
I would have loved you to throw more light on how you went about the fix. In all it's a great post, and a great find.
Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.
To view those questions and the relevant answers related to your post, click here.
Need help? Chat with us on Discord.
[utopian-moderator]
Hi @fego, thank you for your review! I think you've waited for the PO's response. Thanks for that too :) Based on my experience, the response is quite random especially until the end of the each month :) that's why I've just submitted, not waiting any further. Thanks!
zorba님이 blockchainstudio님을 멘션하셨습니당. 아래 링크를 누르시면 연결되용~ ^^
zorba님의 [2019/3/11] 가장 빠른 해외 소식! 해외 스티미언 소모임 회원들의 글을 소개해드립니다.
한글요약: 역시 제가 불편해서 직접 고친 버그입니다. busy에서 한줄에 링크가 두개이상 포함되면 첫번째만 링크가 걸리는 문제가 있더군요. 내친김에 그냥 직접 고쳐서 깃허브에 제출했습니다. 버그 수정은 제가 불편할때만 하려고 하는데 자꾸 불편하게 만드네요ㅎㅎ 얘기해봐야 안고쳐주는 거 뻔히 아니까 직접 고칠 수 밖에 없습니다ㅠㅠ
참고로 이 버그(?)는 steempeak에도 있네요. steempeak은 오픈소스가 아니라서 직접 고칠수가 없습니다. steempeak은 아마 busy코드를 아주 많이 가져다 썼을 것 같은데 아쉽게 오픈소스가 아니네요. 스팀픽이 steem keychain지원하는 점은 아주 훌륭한 것 같습니다.
ps. 참고로 https://staging.busy.org에는 busy수정시에 beneficiary 세팅 안보이는 것 이미 반영되었습니다. 비교적 최근에 한번 staging과 master 머지를 한번해서 두 버전이 큰 차이 없습니다. 현재로써는.
항상 감사합니다 ㅋ 불편함이 더 좋은 세상을 만드네요!
그러게요ㅠㅠ
곰돌이가 @ayogom님의 소중한 댓글에 $0.018을 보팅해서 $0.005을 살려드리고 가요. 곰돌이가 지금까지 총 3546번 $42.131을 보팅해서 $44.110을 구했습니다. @gomdory 곰도뤼~
ㅋㅋㅋ 직접 고쳐주셔서 감사합니다!
말려든것 같아요ㅠㅠ
곰돌이가 @bbooaae님의 소중한 댓글에 $0.018을 보팅해서 $0.005을 살려드리고 가요. 곰돌이가 지금까지 총 3550번 $42.172을 보팅해서 $44.161을 구했습니다. @gomdory 곰도뤼~
@blockchainstudio님 곰돌이가 1.5배로 보팅해드리고 가요~! 영차~
짱짱맨 호출에 응답하였습니다.
sbi4님이 blockchainstudio님을 멘션하셨습니당. 아래 링크를 누르시면 연결되용~ ^^
sbi4님의 Weekly Upvote Report
steembasicincome님이 blockchainstudio님을 멘션하셨습니당. 아래 링크를 누르시면 연결되용~ ^^
steembasicincome님의 Member Delegation Report 12 March 2019
Hi @blockchainstudio!
Your post was upvoted by @steem-ua, new Steem dApp, using UserAuthority for algorithmic post curation!
Your post is eligible for our upvote, thanks to our collaboration with @utopian-io!
Feel free to join our @steem-ua Discord server
Hey, @blockchainstudio!
Thanks for contributing on Utopian.
We’re already looking forward to your next contribution!
Get higher incentives and support Utopian.io!
Simply set @utopian.pay as a 5% (or higher) payout beneficiary on your contribution post (via SteemPlus or Steeditor).
Want to chat? Join us on Discord https://discord.gg/h52nFrV.
Vote for Utopian Witness!