[Busy] cannot edit posts
Project Information
- Repository: https://github.com/busyorg/busy
- Project Name: Busy
Expected behavior
Users should be able to edit posts.
Actual behavior
Users cannot edit posts.
This happens only on the staging server (beta version). But due to many new features and bug fixes, many people also use the staging version. I also first came to know this problem by @lostmine27 and @bbooaae who let me know this problem, since he knows I'm very actively contributing to the Busy project :) I debugged the problem and found the cause and submit the PR.
How to reproduce
- Log in to https://staging.busy.org
- Try to edit any post.
- App: 2.5.6 (beta: https://staging.busy.org)
- Browser: Any
- Operating system: Any
Recording Of The Bug
Try to edit any post, then you'll see the following:
Cause and Fix
This is due to https://github.com/busyorg/busy/pull/2165 Without it, I can still edit.
Beneficiary setting is only possible when a post is created. No modification is allowed afterwards. But currently, by default, the beneficiary setting is on, so when editing, busy is trying to change the beneficiary setting, which is not allowed.
For editing, beneficiary setting shouldn't be modified.
Actually I think beneficiary for busy should be off by default. Users will not like it if unintentionally set especially cause it's 10%. I also suggest it could be variable. 10% is too high especially when it's on by default.
Thanks for your contribution @blockchainstudio
I am unable to review two contributions in a single post, therefore I will only review the issue surrounding editing that you found and provided a fix for. You can add another contribution to the other issues should you wish :)
As always it's great to see that you've reported and provided a PR for the issue found, great work.
The issue, in my opinion, would be a considerable hole in the UX should that be pushed to live, as users have the ability to redirect staging within their busy settings I agree that this would have affected a good number of users. With that said, bugs such as this are to be expected within their staging as new features are pushed more reguarly.
Overall the steps provided were easy to follow and due to the nature of the issue not much explanation was required.
Once again, keep up the good work and look forward to seeing more from you in the future.
Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.
To view those questions and the relevant answers related to your post, click here.
Need help? Chat with us on Discord.
[utopian-moderator]
Hi @tobias-g, thanks you for your review! I see, next time I'll submit only one bug at a time. Probably I may not want to report too many bugs either way (of course I always do on GH), but I'm just curious. is it okay to use a subaccount for some bug reporting? I don't want to fill up my blog with bug reports :) Thanks!
Thank you for your review, @tobias-g! Keep up the good work!
Korean: busy 두가지 버그 리포트입니다.
처음 해당문제를 제게 알려주신 @lostmine27님과 @bbooaae 님께 감사드리고 이 글 payout되면 소정의 성의 표시를 하겠습니다.
감사합니다. 저는 마음만 ^_^
좀전에 확인해보니 고쳐졌습니다. @bbooaae님도 staging 다시 쓰시면 되겠습니다. 고칠대 beneficiary가 세팅된것처럼 나오는데 무시하셔도 됩니다. 설명드린대로 최초밖에 설정을 못합니다. staging에서 최초에 글쓸때만 조심하면 되겠네요ㅎㅎ
참 그런데 두번째 문제인 busy.org 사용자 페이지 접속은 잘 되시나요? 거의 3일째 잘 안되는데 저는. 여러 인터넷 접속 경로를 통해서 해봐도 그래서 무지 불편하네요.
네 저도 페이지 접속이 요 몇일 잘 안된다는 느낌을 받았었습니다.
사실 busy는 글을 올릴 때만 쓰고, 오새는 dclick도 안쓰기로 했고, steemit에서 페이지를 보고 있습니다.
저는 steemit이 제일 편하네요. 야간모드로 쓰니까 살짝 블룸버그 단말기 느낌도 나고 해서 나쁘지 않네요. 야간모드가 지원되는, 모든 댑을 야간모드로 봅니다.
67되신것 축하드려요 ^_^
곰돌이가 @lostmine27님의 소중한 댓글에 $0.017을 보팅해서 $0.006을 살려드리고 가요. 곰돌이가 지금까지 총 3312번 $39.581을 보팅해서 $41.278을 구했습니다. @gomdory 곰도뤼~
주말에 바뻐서 이제야 답글을 드리네요~
busy.org 오늘까지두 잘 안되고 버벅거리더라구요~저도 무지 불편하네요 ㅋㅋ
staging 요거 다시 한번 시도 해보겠습니다 ^^
저도 마음만 받겠습니다. 문제 발생하면 또 여쭤보러올게요 ㅋㅋㅋㅋ
감사합니다 ^^
앗 67 명성도 축하드립니다 !!
곰돌이가 @bbooaae님의 소중한 댓글에 $0.017을 보팅해서 $0.006을 살려드리고 가요. 곰돌이가 지금까지 총 3313번 $39.598을 보팅해서 $41.284을 구했습니다. @gomdory 곰도뤼~
곰돌이가 @lostmine27님의 소중한 댓글에 $0.017을 보팅해서 $0.006을 살려드리고 가요. 곰돌이가 지금까지 총 3304번 $39.491을 보팅해서 $41.184을 구했습니다. @gomdory 곰도뤼~
Separate to my review, I thought it might be worth mentioning as I see you're a regular contributor to the busy codebase. @surpassinggoogle has a site called ulogs which is a fork of busy and at the moment has a good amount of bounty offered against a number of those tasks. He could do with the extra hand and if you're interested in earning a little more Steem for some of those tasks it might be worth a look :)
Hi @tobias-g! thanks a lot for letting me know. I've always been suspecting that there might be a decent fork of busy, and there was! https://ulogs.org/ I'll check it out!
zorba님의 [2019/2/23] 가장 빠른 해외 소식! 해외 스티미언 소모임 회원들의 글을 소개해드립니다.
@blockchainstudio님 곰돌이가 3.2배로 보팅해드리고 가요~! 영차~
짱짱맨 호출에 응답하였습니다.
Hi @blockchainstudio!
Your post was upvoted by @steem-ua, new Steem dApp, using UserAuthority for algorithmic post curation!
Your post is eligible for our upvote, thanks to our collaboration with @utopian-io!
Feel free to join our @steem-ua Discord server
sbi5님의 Weekly Upvotes Report
Hey, @blockchainstudio!
Thanks for contributing on Utopian.
We’re already looking forward to your next contribution!
Get higher incentives and support Utopian.io!
Simply set @utopian.pay as a 5% (or higher) payout beneficiary on your contribution post (via SteemPlus or Steeditor).
Want to chat? Join us on Discord https://discord.gg/h52nFrV.
Vote for Utopian Witness!
gomdory님의 곰돌이 일기장 2월 24일 - 댓글 구출 3200개 돌파!