Dropping last reference to httplib in PyGithub

in #utopian-io6 years ago (edited)

Repository

https://github.com/PyGithub/PyGithub/
PR : https://github.com/PyGithub/PyGithub/pull/998

New Features

Simplify inner http queries by migrating from httplib to requests package. As notified in python documentation:

The Requests package is recommended for a higher-level HTTP client interface.

The work was mostly done in a previous PR but this last chunk was missing.

GitHub Account

https://github.com/blatinier

Sort:  

Thanks for the contribution, and welcome to Utopian, @blatinier! It's very cool to see you helping out with such a big project as PyGithub! Since you are new to submitting contributions to Utopian I would like to point out a couple things:

First of all I'd recommend you read this guide on what we look for when reviewing development contributions. Also, since we use an exponential scoring system (which affects the reward) it's more beneficial to combine stuff that is relevant to each other (e.g. your two contributions) since the amount of work is part of the score, for example.

Other than that I don't have much to say. I look forward to seeing more of your contributions in the future!


Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.

To view those questions and the relevant answers related to your post, click here.


Need help? Write a ticket on https://support.utopian.io/.
Chat with us on Discord.
[utopian-moderator]

Thanks for your feedback! As for the merged post for contribution, it's ok to reference two PR on the same post? Because the maintainer specifically ask for my two pieces of work to be split in two distinct PR.

Anyway thanks for your project, rewarding openSource contributors is a great deal!

Yes, as long as they are related to the same project it's fine.

Thank you for your review, @amosbastian! Keep up the good work!

Hi @blatinier!

Your post was upvoted by @steem-ua, new Steem dApp, using UserAuthority for algorithmic post curation!
Your post is eligible for our upvote, thanks to our collaboration with @utopian-io!
Feel free to join our @steem-ua Discord server

Hey, @blatinier!

Thanks for contributing on Utopian.
We’re already looking forward to your next contribution!

Get higher incentives and support Utopian.io!
Simply set @utopian.pay as a 5% (or higher) payout beneficiary on your contribution post (via SteemPlus or Steeditor).

Want to chat? Join us on Discord https://discord.gg/h52nFrV.

Vote for Utopian Witness!

Coin Marketplace

STEEM 0.16
TRX 0.15
JST 0.028
BTC 56586.95
ETH 2389.49
USDT 1.00
SBD 2.34