You are viewing a single comment's thread from:
RE: Teleports DrugWars - Android Phone, Tablet, and TV app | v1.0 - Unofficial
It seems that you have created an app that basically opens the mobile version of https://drugwars.io/ in fullscreen, or am I wrong? I guess it's pretty cool, but it only really saves a couple of clicks I guess. I think it's better if they make it into a PWA instead.
Some feedback:
- Code is very basic, and probably largely copied and pasted from the documentation (e.g. here and here), so I'm not exactly sure how much work went into this. It would be best if you try to make this more clear in the future.
- Variables names such as
a
,b
andy
should not be used. - Spacing and indentation is very inconsistent. I even saw some code with like 10 lines of nothing, why is this? I recommend you use a linter.
- Duplication of code that could be refactored into a function (e.g. the make fullscreen code).
- A lot of pictures of you out playing the game, but it would've been better to have more information about what you actually implemented, but I guess there wasn't much more to say than you already did.
Will be interesting to see what other stuff you post about. Any plans for making something yourself, or will you only be porting stuff from others?
Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.
To view those questions and the relevant answers related to your post, click here.
Need help? Chat with us on Discord.
Hoi, @amosbastian Thank you for reviewing
Yes, the app loads the game website in fullscreen immersive mode and the goal of the Teleports apps are to have it work in a more convenient way compared to opening the website with a browser, it is beside a normal phone/tablet app also a Android TV compatible app. (by default it is only one of the two). A own app that shows the Teleports apps catalog is something as well to add later, having a few apps ported and optimized and having a landing page have a higher priority, but it is looked into.
Also would like to fix the selection box issue on Android TV, and add a settings menu.
i will be improving on the points you suggested and document the changes and fixes better, and while the first few apps are ported and released, new features and improvements will be added to them to make them more convenient to use and more compatible with different devices. They will eventually be listed on a website / landing page with a introduction about each dapp project and the app links.
🎁 Dear @techtek,
SteemBet Seed round SPT sale is about to start in 2 days!
When our started the development of SteemBet Dice game, we couldn’t imagine that our game would go so viral and that SteemBet would become one of the pioneers in this field.
In order to give back to our beloved community, we’ll distribute 4000 STEEM to SPT holders immediately after Seed sale. Plus, investors in this earliest round will be given 60% more tokens as reward and overall Return on Investment is estimated at 300%!
Join the whitelist on SteemBet webiste now and start investing! Feel free to ask us anything on Discord https://discord.gg/tNWJEAD
Thank you for your review, @amosbastian! Keep up the good work!