You are viewing a single comment's thread from:
RE: SteemAX Update to v0.3 ~ New Features
Thanks for the contribution, @learnelectronic! It seems like a quite a lot of work went into this contribution, and although a lot was that was refactoring code, there are definitely still some improvements that could be made. I would definitely recommend getting a linter, as this would help prevent the same mistakes from happening
- Too many blank lines - you inserted a lot of them when it's not needed
- There's a lot of trailing whitespace in places
- Don't add whitespace before '('
- Continuation lines over-indented or under-indented a lot of the time
- In
axe.py
there are loads of unused variables - In
axtrans.py
you useself
a lot, but the instance ofAXtrans
does not have those members the majority of the time you use it
It is great that you kept everything below a width of 80 characters, though!
Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.
To view those questions and the relevant answers related to your post, click here.
Need help? Write a ticket on https://support.utopian.io/.
Chat with us on Discord.
[utopian-moderator]