RE: Steemmonster Discord Bot - All Infos At Your Fingertips - Open Source Bot for your convenience ;)
Thanks for the contribution, @jedigeiss! I don't play Steem Monsters, so bare with me, haha. The bot does look really cool, it's only unfortunate that it's just in German for now.
It's obvious a lot of work went into this, which is always great to see. It's also good to see that most of the code is PEP8 compliant, as it makes it a lot more readable, especially for someone who doesn't know all the Steem Monsters lingo like me.
There are in my opinion some small improvements that could be made, so I'll mention a few:
- For the rarity (and maybe edition and gold) you could use a constant instead of just the numbers 1 to 4.
- Why always
response = ""
and what iscnt2
? You could reverse it and count down from 10 with a try except for the response. - What is
ranking[2]
,ranking[3]
etc? Maybe you could make a class so you can just call the properties, e.g.ranking.player_name
which would make it a lot more maintainable and readable. Same for the other things likedata[0]
.
Another thing you could possibly do is create a setup.py
and put the version in there instead of having it in the filename itself. I am sorry if I come over as a bit nitpicky, but my only intention is to try and help.
Other than that the project looks really great, so I'm sure people are desperately waiting for the English version. Looking forward to seeing the other features you come up with for future contributions!
Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.
To view those questions and the relevant answers related to your post, click here.
Need help? Write a ticket on https://support.utopian.io/.
Chat with us on Discord.
[utopian-moderator]
Thank you for your review, @amosbastian! Keep up the good work!