You are viewing a single comment's thread from:

RE: update for beem - adding claim account creation to beempy and support for whaleshares

in #utopian-io6 years ago

Thanks for the contribution, @holger80! I love using beem so I'm happy to see that you are still bringing out regular updates. Adding the claimaccount command to beempy is a great addition, although I'm not sure I'm even able to use it haha.

Anyway I have some feedback regarding some small things: it's probably better to use click.echo() instead of print() as "it has improved support for handling Unicode and binary data that does not fail no matter how badly configured the system is." I am also not sure if you explicitly want to check for the None object, but the code has a lot of if X is not None statements. Maybe it's better to simply use if not X if the situation above doesn't apply. And finally one last nitpick: keep your line width < 80 😋

Looking forward to seeing more awesome updates in the future! Keep up the great work, Holger!


Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.

To view those questions and the relevant answers related to your post, click here.


Need help? Write a ticket on https://support.utopian.io/.
Chat with us on Discord.
[utopian-moderator]

Sort:  

Thank you for your review, @amosbastian!

So far this week you've reviewed 20 contributions. Keep up the good work!

Coin Marketplace

STEEM 0.29
TRX 0.12
JST 0.032
BTC 60318.52
ETH 2983.06
USDT 1.00
SBD 3.78