You are viewing a single comment's thread from:

RE: steem android app update, introducing new ui and image downloader

in #utopian-io5 years ago

Being able to download the pictures, and seeing all the pictures of a post, is a pretty cool feature - great work! Curious why you renamed it to steem though, as that's pretty confusing, and steemer was a fine name imo.

Anyway, as for the code:

  • Check this guide on how to write commit messages.
  • From what I've read, it's better to use a for-each loop instead of a traditional for loop, except when the index is required or the list has to be modified. Imo for-each is a bit more readable as well.
  • A lot of commented out code and console logs left in. Should remove those to prevent clutter and improve readability.
  • Some small inconsistencies across the code, maybe there is a linter you could use to prevent this?

Good luck with the rebranding and further development!

Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.

To view those questions and the relevant answers related to your post, click here.


Need help? Chat with us on Discord.

[utopian-moderator]

Sort:  

Thank you. The app was available in the play store earlier, but they banned my account for a different app of mine as it was competing against theirs, it now makes me look bad but that is the truth so will be renaming this app when I reupload to a new google dev account.

I'll read that commit link, and run the linter. Thank you once again.

Thank you for your review, @amosbastian! Keep up the good work!

Coin Marketplace

STEEM 0.17
TRX 0.13
JST 0.028
BTC 56681.24
ETH 3016.79
USDT 1.00
SBD 2.28