I've been playing Drugwars a bit (I used to play a game called Tribal Wars which, could also be a interesting if implemented on the Steem blockchain imo), and it's pretty awesome how they made it in under a month. It's really cool to see you're already creating a Python package for it as well - hopefully you can keep it up to date with the many changes happening!

As for the code; overall the quality is very high as usual, and I could only spot a couple of issues, but here's some feedback anyway:

• Think you could use @classmethod or @staticmethod for do_exit in shell.py.
• Great that you included some tests, but you could move test.py to tests/ and imo pytest is a lot better to use than unittest. The person who converted me said this: "proverb of the modern python developer: life is too short to not use pytest." ;)
• Don't need to assign a variable here (very minor, lol).

Keep up the great work, Emre! People should definitely be able to make some useful tools for Drugwars using this.

Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.

To view those questions and the relevant answers related to your post, click here.

Need help? Chat with us on Discord.

[utopian-moderator]