RE: Heisenberg 0.1.1: Rest API wrapper and update on "attack" command
I've been playing this game on and off, but couldn't really see the point and was quickly getting bored of it. Hopefully with them reintroducing the battles it might become a bit more interesting, but I will have to wait and see. Imo if they add something that you can make your own mafia with others then I would definitely get on board.
As for the code:
- There isn't a matching distribution for
drugwars_heisenberg
-heisenberg_drugwars
does exist, but it's only version 0.1.0, and with this post it's meant to be 0.1.1. - In
shell.py
do_exit
can be a function sinceself
is never used, and in the filetest.py
the variableheist
is never used. - Everything is well commented and of high quality, although there are some magic numbers like
0.99
and0.005
which could be made into constants.
Great work making sure it stays up to date, and I am sure you are up to the challenge of continuing to do this! I've seen a lot of posts from people complaining about the fact that so much is changing constantly, which must be a headache for you, haha.
Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.
To view those questions and the relevant answers related to your post, click here.
Need help? Chat with us on Discord.
Thanks for the perfect review @amosbastian. Package naming issues are fixed. Will consider the other changes in the next iteration. 👍
Thank you for your review, @amosbastian! Keep up the good work!