You are viewing a single comment's thread from:

RE: [Aristotle App] Add Contribution, Weekly LM Reports and more...

in #utopian-io6 years ago (edited)

Thanks for the contribution, @dimitrisp! It's very cool to see the effort you are putting in to keep the Greek translation team running as smoothly as possible - great stuff!

As for the review; I think there are some places like IsSteemLink where you could use a regex to see if it's valid, and then split it by groups to get the information you need. Not really important though, just thought I'd mention it.

In some places there are magic numbers, like for example $hasaccess == 2. What is 2? I personally would define some constants and use those instead, which should improve the readability of the code.

The commit messages are already great, so my only suggestion is that you should try and keep the subject a bit shorter. Around 50 characters is normally the recommended number.

As it was already mentioned by @codingdefined and you said you are already working on it, I won't comment on the number of nested if statements haha.

Looking forward to seeing what other great features you add - it's really coming along nicely! P.S. you should making think about using pull requests, as it will save you some effort in linking all the commits (I know how tedious that is, haha).


Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.

To view those questions and the relevant answers related to your post, click here.


Need help? Write a ticket on https://support.utopian.io/.
Chat with us on Discord.
[utopian-moderator]

Sort:  

I think there are some places like IsSteemLink where you could use a regex to see if it's valid, and then split it by groups to get the information you need

Yeah that's probably how I'm going to handle this

In some places there are magic numbers, like for example $hasaccess == 2. What is 2? I personally would define some constants and use those instead, which should improve the readability of the code.

I know it is a bad way to do this, but those magic numbers are access levels, and I'm still designing the whole concept in my mind, so I'll fix it soon.

Thank you for all the suggestions @amosbastian, I really enjoyed your review, and I'll do my best to make this software as great as possible, as it will be a great help to use it! :)

Thank you for your review, @amosbastian! Keep up the good work!

Coin Marketplace

STEEM 0.30
TRX 0.11
JST 0.031
BTC 68622.46
ETH 3788.62
USDT 1.00
SBD 3.66