You are viewing a single comment's thread from:

RE: [New Features on steemr] Diagrams in the Shiny app for the statistics of the Steem CN community!

in #utopian-io6 years ago

Thanks for the contribution, @dapeng! Was wondering if scner is actually a thing? To me it seems like a very vague name for a function, but I could be completely missing something, haha.

Some thought(s) about the contribution:

  • Since you are including quite a lot of code in one commit it is maybe better to create a pull request instead and split up the work over multiple commits, where each commit message would describe whatever was implemented in that particular commit. Or I would recommend separating the commit's subject and body with a blank line and writing some more information about what was implemented in the body, for example:
Add image display for `scner()`

This commit adds the following features:
* 1
* 2
* 3

This guide could be a good reference. Also, I don't know if you saw this guide, but I'd definitely recommend you check that out as well if you haven't.

I look forward to seeing more of your contributions in the future!

Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.

To view those questions and the relevant answers related to your post, click here.


Need help? Write a ticket on https://support.utopian.io/.
Chat with us on Discord.
[utopian-moderator]

Sort:  

Thank you very much for your review and helpful suggestions! I am not a professional programmer, and I do learn a lot from the guidelines you mentioned! Regarding scner(), it was introduced in a previous post:

Thank you for your review, @amosbastian!

So far this week you've reviewed 5 contributions. Keep up the good work!

Coin Marketplace

STEEM 0.31
TRX 0.11
JST 0.031
BTC 67916.87
ETH 3819.97
USDT 1.00
SBD 3.67