You are viewing a single comment's thread from:

RE: Supbot API | Whatsapp Group Chatbot API | Developement update #3

in #utopian-io5 years ago

Thanks for the contribution, @adam-saudagar! I didn't realise WhatsApp didn't have any bot support and that's honestly very strange. It's great to see you have managed to find a way around this and are implementing useful features for people to use!

Your commit messages and the comments/documentation you had added are really good. It definitely makes it very easy to understand what's happening in the code. One thing I'd like to recommend is using a linter, as there are some minor inconsistencies in the code itself (like the indentation), but other than it looks great!

Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.

To view those questions and the relevant answers related to your post, click here.

Need help? Write a ticket on
Chat with us on Discord.


wow, that was a fast, thanks for reviewing my post,

can you let me know where specifically there was inconsistencies in indentation, I do use intellij idea it should take care of it.

Have a great day 😄

It's my pleasure! For example in here

public Helper getHelper() {
    return new Helper(
            "group show\n" +
                    "group add <gid>\n" +
                    "group remove <gid>",
            "group add group1",
            "Add, Remove, Show groups that can be recognized by the bot"

I think the strings (each continuation line) should be indented by the same amount, but I could be wrong since I don't use Java much. There are also some things with too much vertical whitespace and missing horizontal whitespace (e.g. between if and the opening bracket). Maybe SonarLint could help with stuff like that (never used it personally).

Thank you for your review, @amosbastian!

So far this week you've reviewed 5 contributions. Keep up the good work!

Coin Marketplace

STEEM 0.17
TRX 0.09
JST 0.028
BTC 27002.73
ETH 1674.16
USDT 1.00
SBD 2.22