ULOG #16: Adding Overseeing Uloggers

in #ulog • 5 years ago

image.png

@surpassinggoogle contacted me to address an issue regarding an incomplete task. The original task request was here which was broken into smaller tasks. And the original github issue here.

This contribution is a modification of the Overseeing Uloggers component.

Repository

https://github.com/surpassinggoogle/UlogsV2

Issue

https://github.com/surpassinggoogle/UlogsV2/issues/202

Pull Requests

https://github.com/surpassinggoogle/UlogsV2/pull/207

Implementation

As discussed with Terry, the main issue he had was that this component (Ulog Overseers) should only contain the @ulogs account. I'm not sure what his future plan on how to add to this list, but for the moment, I hard-coded the account list (array) to contain only the 'ulogs' account when getting the account information from the blockchain.

Here's an explanation of each component in the code:

  1. src/client/app/Sidebar/RightSidebar.js - originally the right side bar used the InterestingUloggersWithAPI component which contained the list of certified uloggers (accounts followed by @uloggers). Since Ulog Overseers is different, I decided to create a new component
  2. src/client/components/Sidebar/InterestingUloggersWithAPI.js - this was a change based on the announcement made by @steemitblog regarding the API changes;
  3. src/client/components/Sidebar/OverseeingUloggers.js - the new component
  4. src/client/components/Sidebar/UlogOverseer.js - as mentioned in the github issue, it should not contain the Follow button; I opted to create a new UlogOverseer component.
  5. src/client/locales/default.json - added the new "Overseeing Ulogger" string

Feature in Action

UlogOverseers.png

Lesson Learned

Reading and understanding user specification is a must in software development. For this TR, all the details were included in Terry's post. From my assessment, there was a clear miscommunication between Terry and the original dev.

For the other sub-tasks mentioned in the github issue, I'll address it in another time since this was the contribution I was only able to accommodate today.

GitHub Account

https://github.com/eastmaels

This post was made from https://ulogs.org

#utopian-io #development #steemdev
5 years ago in #ulog by
$33.31
  • Past Payouts $33.31, 0.00 TRX
  • - Author $25.38, 0.00 TRX
  • - Curators $7.94, 0.00 TRX
716 votes
Reply 7
Sort:  
  • Trending
    • [-]
     5 years ago 

    Thank you for your contribution @eastmael !

    1. I would expect to see some comments on some code such as noUsers is hard to understand at a glance. If it means No-Users, why can't we figure this out by checking users array?
    2. I'd like to see some tests regarding getCertifiedUloggers
    3. Could we make the code simpler and prettier using async/await?

    Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.

    To view those questions and the relevant answers related to your post, click here.

    Need help? Chat with us on Discord.

    [utopian-moderator]

    [-]
     5 years ago 

    These are noted. Thank you for the feedback.

    Posted using Partiko Android

    [-]
     5 years ago 

    Thank you for your review, @justyy! Keep up the good work!

    $0.00
      Reply
      [-]
       5 years ago 

      Hey, @eastmael!

      Thanks for contributing on Utopian.
      We’re already looking forward to your next contribution!

      Get higher incentives and support Utopian.io!
      Simply set @utopian.pay as a 5% (or higher) payout beneficiary on your contribution post (via SteemPlus or Steeditor).

      Want to chat? Join us on Discord https://discord.gg/h52nFrV.

      Vote for Utopian Witness!

      [-]
       5 years ago 

      That's great thing you added thanks for doing your level best :)

      [-]
       5 years ago 

      Hello @eastmael! This is a friendly reminder that you have 3000 Partiko Points unclaimed in your Partiko account!

      Partiko is a fast and beautiful mobile app for Steem, and it’s the most popular Steem mobile app out there! Download Partiko using the link below and login using SteemConnect to claim your 3000 Partiko points! You can easily convert them into Steem token!

      https://partiko.app/referral/partiko

      $0.00
        Reply
        [-]
         5 years ago 

        Hi @eastmael!

        Your post was upvoted by @steem-ua, new Steem dApp, using UserAuthority for algorithmic post curation!
        Your post is eligible for our upvote, thanks to our collaboration with @utopian-io!
        Feel free to join our @steem-ua Discord server

        $0.00
          Reply

          Coin Marketplace

          STEEM 0.27
          TRX 0.11
          JST 0.030
          BTC 70453.17
          ETH 3808.25
          USDT 1.00
          SBD 3.51