Steem Blockchain PR Submitted: Clarifying the Number of Witnesses to HF
For users that are reading the Steem blockchain code, comments that explain how the code works are very important. An incorrect comment can cause confusion, because users may rely on what the comment says rather than spending the time to understand how the code is written.
Prior to HF 17/18, there were 19 'top witness' positions, 1 'backup witness', and 1 POW/miner per "round". In HF 17/18, the POW miner position was removed, and an additional top elected witness position was added. There are now 20 'top witnesses' and 1 'backup witness' per round.
The comment that indicated how many witnesses are required to hardfork was not updated to indicate that there are now 21 DPOS witness positions per round (20 top witnesses, and 1 backup witness). I submitted a pull request to the Steem GitHub repository to correct the comment:
https://github.com/steemit/steem/pull/1042
It is a small change, but hopefully it will make things clearer for future developers/users who are reading through the code and trying to understand how it works!
Transparency, preciseness and communication are exactly what this community needs - especially centered around HF it seems.
Thanks for doing this!
I second this :)
I third this :) :) :)
Welcome!
Internal PR made https://github.com/steemit/steem/pull/1046
oh good to know, all are top20 equal like before ?
Yes.