You are viewing a single comment's thread from:

RE: Complete guide to understand rewards in HF21 [Part 1]

in #steem2 years ago (edited)

I'm confused about this:

Last minute vote. If the vote is done 5 minutes before the payout then the reward shares are decreased proportionally to the remaining time for the payout. That is, half before 2.5 minutes, and 0 just at time of the payout.

I thought the "last-minute" window was 12 hours, right now, and this wasn't going to change with HF21?!

There is however a 5 minute window with reduced curation rewards right after the post has been made.

Did something get mixed up here or is the "last-minute" really being decreased to 5 minutes?!

P.S.: I checked on github

L27: #define STEEM_UPVOTE_LOCKOUT_SECONDS (60*5) /// 5 minutes
L28: #define STEEM_UPVOTE_LOCKOUT_HF17 (fc::minutes(5))
[...]
L45: #else // IS LIVE STEEM NETWORK
[...]
L61: #define STEEM_UPVOTE_LOCKOUT_SECONDS (60*60*12) /// 12 hours
L62: #define STEEM_UPVOTE_LOCKOUT_HF17 (fc::hours(12))

it's a bit confusing still as it's indeed defined as 5 minutes earlier in the same file, but I'd assume that's a testnet-only setting and the later definition overwrites that.

Sort:  

From HF17 to HF19 the window was 12 hours.
But it was changed in the Hardfork 20. Now it is 5 minutes.

https://github.com/steemit/steem/blob/bdf0fb51361c26537428efcd9a65433ffe09abbf/libraries/chain/steem_evaluator.cpp#L1958-L1961

which is set to 12 hours according to the definition posted above (edited for clarity)?!

https://github.com/steemit/steem/blob/v0.21.0/libraries/protocol/include/steem/protocol/config.hpp#L61-L62

Ohh I see. I was looking the value for testnet. You are right, it is 12 hours. I will change it. Thanks.

No worries, I wasn't 100% sure myself until I actually looked into the code.

Either way, your posts on the matter help me greatly with wrapping my head around the new rewards.

Thanks for taking the time to put this all together!

!SHADE 2
Thanks for sharing on Pimp Your Post Thursday

Coin Marketplace

STEEM 0.74
TRX 0.09
JST 0.072
BTC 54541.54
ETH 4072.79
BNB 591.56
SBD 6.99