You are viewing a single comment's thread from:

RE: Upvote bot in less than 10 lines of code

in #steem • 8 years ago (edited)

Hey @xeroc, love your stuff but I found a small bug with this logic:

if c["author"] in authors:

This will be true for substring matches in authors.

So if authors contains a name such as "longtestname"
and c["author"] contains a name such as "name" or "test"

It will evaluate as true

(Python is still new for me)

8 years ago in #steem by
$1.61
  • Past Payouts $1.61, 0.00 TRX
  • - Author $1.21, 0.00 TRX
  • - Curators $0.40, 0.00 TRX
12 votes
Reply 3
Sort:  
  • Trending
    • [-]
     8 years ago (edited)

    Thanks for taking a closer look, but since this expression

    "a" in ["aa"]

    evaluates to False in python, I'd say that python interprets all elements of authors independently and in full. That's because authors is an array or list.

    If it was just a single author then you would be right since

    "a" in "aa"

    evaluates to True

    Agreed?

    $1.02
    • Past Payouts $1.02, 0.00 TRX
    • - Author $1.02, 0.00 TRX
    • - Curators $0.00, 0.00 TRX
    2 votes
    Reply
    [-]
     8 years ago 

    Just tested this more and found out what the error was:

    If you include the single quotes around the array, both statements return True

    stringList = '["list","of","strings"]'
print("list" in stringList)
True
print ("li" in stringList)
True

    But if you remove the single quotes around the array, it functions as intended:

    stringList = ["list","of","strings"]
print("list" in stringList)
True
print ("li" in stringList)
False

    Hope this helps!

    $0.03
    • Past Payouts $0.03, 0.00 TRX
    • - Author $0.03, 0.00 TRX
    • - Curators $0.00, 0.00 TRX
    2 votes
    Reply
    [-]
     8 years ago 

    In the first case, the stringList is actually a simple string and is not interpreted as an array. that's why the test returns true in both cases.

    $1.08
    • Past Payouts $1.08, 0.00 TRX
    • - Author $1.07, 0.00 TRX
    • - Curators $0.01, 0.00 TRX
    6 votes
    Reply

    Coin Marketplace

    STEEM 0.16
    TRX 0.15
    JST 0.029
    BTC 56596.99
    ETH 2394.78
    USDT 1.00
    SBD 2.32