Me and STEEM (2)
About the latest bug fix in STEEM v0.4.2
The latest commits of STEEM v0.4.2 fixed a forking issue introduced in v0.4.1.
(picture by @pharesim in STEEM slack channel)
Here is my version of the story.
Yesterday we (STEEM witnesses) noticed some suspicious error/warning messages in the console of steemd. Some nodes were rejecting blocks produced by other nodes! WARNING! It looks like a forking issue! Due to this, some witnesses were missing blocks randomly, one of them is @bitcube. Most of the missing blocks are triggered by @liondani who was trying to up-vote his own comment (and also a few others were doing so).
pfunk [10:58 AM] hmm steemd console just went red
[10:58] it didn't like liondani's upvotes I guess :stuck_out_tongue:abit [10:59 AM] me too
[10:59] looks like someone is on a forkpfunk [10:59 AM] Could not create object! Most likely a uniqueness constraint is violated. abit can you translate that to English? :simple_smile:
liondani [10:59 AM] I just tired to upvote my post
[11:00] 2 times and 2 times the votes get in previous state
[11:00] this is the post
[11:00] https://steemit.com/videos/@liondani/steem-a-blockchain-based-social-media-platform#comments
[11:00] I wil try again in 10 seconds
[11:01] prepare for another red screen
[11:01] here we go
[11:01] same thing!!!!!abit [11:07 AM] it's strange. @liondani's voting transaction got into @bitcube's block, but rejected by my node
[11:09] block 1321447 is @bitcube 's turn, but it got rejected, so missed a block, and a good block is produced by @wackou
After further investigation, we found that @bitcube is running steemd v0.4.1, while most of others are running v0.4.0. So there might be an issue with v0.4.1. Then I fired an issue to github, and notified in slack channel and Telegram channel that all witnesses should stick with 0.4.0 until a fix is released.
By looking into the code, I found that in v0.4.1, when a comment is being edited, all votes on the comment will be removed, so voters are able to vote on the comment again. This behavior is different from which in v0.4.0. After commented this to github, devs got the issue fixed and released v0.4.2 quickly.
Happy end.
Thanks for the summary!
I have updated to later master...
I still can't up-vote the specific post .. I guess it is normal until all witnesses are on the same release(?)
1549747ms th_a steem_evaluator.cpp:569 do_apply ] o: {"voter":"liondani","author":"liondani","permlink":"steem-a-blockchain-based-social-media- *platform","weight":10000} *
It's intended.. v0.4.0 and v0.4.2 have same behavior: one account can only vote on a comment once. v0.4.1 has different behavior that an account can re-vote on a comment after it's edited.