Taking on someone else's child, good or bad idea Part 2

I wrote this post 6 months ago, I didn't get much feedback , I got 4 upvotes and a couple of messages so thought Now I know a lot more members on here, what do you think, would you, have you done the same as me, what was the outcome?
I will copy and paste the post here so you don't have to go hunting for it plus add on a update now she has been with us over 2 years.

My youngest daughter has had a best friend for quite a few years they talked all the time, me and my daughter talked all the time too so when her best friend was having a hard time at home she talked to me for advice. I went through a rough childhood having parents who didn't care , who thought it was funny to see there kids suffer or in pain so I knew how she must be feeling, Me and her friend used to talk and I tried to help but you can't say to much you can just point them in the right directions and tell them who they should talk to.

This went on for quite some time I would hear them talking with them both getting upset, her parents were super strict, she wasn't allowed to take her phone to school, her parents were allowed to read her messages, she was controlled even when she got a apprenticeship they took most of her money, they had her doing all the housework and looking after her younger brother whilst they slept all day,

I have 2 daughters my oldest has ADHD, ODD & Aspergers so bringing her up was really hard, We did it though and were super proud of her, she has moved out and is doing really well, when she has her ADHD/Asperger moments mum is always there . She moved out so we sort of thought yes our lives will get easier, took over a year to empty her bedroom, its a box room, before she left she couldn't get into it to sleep so slept on the sofa, she was a hoarder and saved everything. Took a while but we managed to get it empty, we had plans for that room it was going to be a dressing room for my youngest, somewhere to keep all her make up and hair stuff.

THEN

I got a phone call from My daughters friend saying she had walked out, she couldn't take anymore. She was just 16 out on a dark night, her parents had opened the door for her then closed it after her. So I told her to come here, that was 2 years ago come October, she's been here ever since We decorated her room, bought a sofa bed and new curtains and she made it her new home. She is a lot happier, she has cut her parents out of her life for the time being (they haven't tried to get her back) she is now apart of my family and has fitted in after a bad start.

I asked her if she was interested in getting a place of her own she said " I'm never leaving here ". I think it was a bad idea at first but now happy that we have done it.

UPDATE
Demi has now been with us for 2 years and 3 months, she still goes to see her nan and younger brother but never speaks to her parents, she doesn't want to talk to them, I think they have given up phoning her as she never answers, NOW me being a mum I would never give up calling, I would continue to try and have a relationship and sort our problems out. I really don't think its all her parents fault as we have had some really hard times with her, she can be very childish at times, everything scares her, she breaks things, isn't very careful and doesn't really care about much. We have talked to her and honestly the impression I get is she never had her own things, now she has her own bedroom with her own space and things she has bought for herself plus things we have bought her has made her realise she has to be more careful and look after her things. Her parents bought her things but she wasn't allowed to take them with her as they had bought things for her e.g hairdryer, straightners, Playstation they were still there's and had to stay there. Now she knows that when she ever leaves here she will take what's hers. When she came to live with us she was very moody, everything upset her so we talked saying if something if there is something wrong we don't go in a mood we talk about it and see if we can sort it out, It took a while but eventually she did start talking more and her moods disappeared, she smiles and laughs a lot more now,

Her parents told us they would phone us once a week to check up on her, that lasted 2 weeks never heard anything from the, I am disgusted that no one from her family have come and checked us out, we could be bad people but not one of her family has introduced themselves to us, Whereas I would be there letting them know who I am and that I cared.
She's now nearly 19 so she should be old enough to know what she wants but still we have to talk about things help her focus and how to interact with people especially her employer as she constantly wants to walk away. Its the consequences she doesn't understand, its all about here and now not thinking what could happen.

We all still get on, there's been the odd argument which is easily sorted and then we are friends again, I think she has learned a lot from being in our family and seeing how a family works, its not look after yourself its look after each other too. Sharing, making sure you don't take everything for yourself, she did at first, she hoarded a lot of food in her bedroom, we talked about this a lot, its only been recently that she has stopped and now makes sure there is something for everyone, she's not going to go hungry there's enough for everyone. Its such a shame seeing a 17 yr old hungry and scared to ask for something to eat.

She now tells us she loves us, she loves living with us and never wants to leave, one day she will have to but now I know she can look after herself and be independent.