You are viewing a single comment's thread from:

RE: Updating the League of Legends PMTC

Thanks for the review, Helo! I agree about the SVG being a bit messy, but I didn't want to add an entire package just so I could use 1 icon, and it was a last minute thing I added. Maybe I'll convert it to a separate icon component and use that instead.

As for it being less hardcoded: definitely! In the previous version I made a hardcoded champions.json file and was using that. Obviously with new champions being released this quickly became annoying to maintain, so now it retrieves the current patch from Riot's API and then uses that to find an up-to-date list of champions.

I'm also glad to say it has already been used by others today, as you can see here.

Coin Marketplace

STEEM 0.29
TRX 0.32
JST 0.050
BTC 99218.05
ETH 3992.85
USDT 1.00
SBD 3.99