RE: Hacktoberfest #1: Beem minor fix
This is a great contribution to see in the development category. Very well explained the problem and solution. The changes include also docstrings and follow the python best practices.
Even though the amount of code is small compared to what we have on average, I really like the contributions includes collaboration with the project owners.
If the pull request had include a unit test about the case, that would be perfect.
Good luck in the Hacktoberfest. I had one of their t-shirts. Still using it :)
Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.
To view those questions and the relevant answers related to your post, click here.
Need help? Write a ticket on https://support.utopian.io/.
Chat with us on Discord.
[utopian-moderator]
Hey, thanks for the review. I will look into tests more and how I could include them in potential PRs. I will do my best in the Hacktoberfest, already submitted another PR with yet another minor fix in beem. But still waiting for someone to review it. :)
I guess I will spend my time with the API endpoints and Beem. Especially the Condenser API and even the AppBase APIs seem to be broken in some cases. Though, I am not sure if I had any chance in reporting them to Steem repo or just making Beem's docs better and spot some bugs if there are any.
Thank you for your review, @emrebeyler!
So far this week you've reviewed 2 contributions. Keep up the good work!