You are viewing a single comment's thread from:
RE: Notification bug fixes and new upload endpoint switcher on d.tube
Thank you for your contribution.
- there is a extra '1' at the shuffle function and you might consider using e.g. underscore to avoid re-inventing the wheel.
Session.get('uploadEndpoint') === 'uploader.oneloved.tube'
could be extracted as it appears more than once. The endpoint and the corresponding handler could be refactored.- comparing the error message e.g. here is not a good idea. You could use error code instead.
- jslint/eslint prefers semi-colons.
Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.
To view those questions and the relevant answers related to your post, click here.
Need help? Chat with us on Discord.
Thank you for your review, @justyy! Keep up the good work!