You are viewing a single comment's thread from:
RE: Actifit BOT Development Updates: Exchange Functionality, Historical Data, Endpoints & More
Thank you for your contribution.
- there are quite a lot of
console.log
, as I understand this might be useful sometimes (are they visible to the end-users?), you might want to extract the logging function into a separate Logger class, which could be configured to write to log files (persistent for debuging purpose) - You might want to format your code, as some are not properly styled.
- for Javascript, you might want to cache array length in a for loop such as
for (let i = 0, len = groupedTxs[index].length; i < len; i++) {
- Inconsistent usage of semi-colon
var
could be completely replaced by eitherlet
orconst
- commented out code that is misleading. such as
- Missing exception handling when e.g. MongoDB is not accessible.
- Nested try-catch all catch general exceptions is not a good idea e.g. code-smell.
- Regarding this commit not sure why it has shown changes even quite a lot of code are actually un-changed.
Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.
To view those questions and the relevant answers related to your post, click here.
Need help? Chat with us on Discord.
Thank you for your review, @justyy! Keep up the good work!