Steem Witness vote removal highlight and confirmation

in #utopian-io5 years ago (edited)

View this post on Hive: Steem Witness vote removal highlight and confirmation


Repository

Repo: https://github.com/steemit/wallet
Pull request: https://github.com/steemit/wallet/pull/41

Context

The official Steemit Witnesses page, contains several bugs and limitations that sometimes leads to users removing a witness vote when they actually wanted to cast a vote for the witness. This pull request is adding more visibility on such action.

Bug fixes

Tooltip bubble on vote removal chevron icon

I added a tooltip (info bubble) that shows on mouse over on the chevron icon. Initially, the tooltip was displaying "Vote" regardless of if the click would vote or actually remove the vote on the witness. This fixes it and will show "Vote" or "Remove Vote" accordingly.

Screen Shot 2019-04-30 at 12.26.59 pm.jpg

New features

Witness vote removal confirmation modal

The tooltip mentioned above has a delay before displaying, so users can still accidentally click on the chevron icon thinking they need to click on it to apply their vote. This is especially true for witnesses not displayed in the list at the top of the Witnesses page.

Upon click on the chevron, a new modal window will popup asking for confirmation before actually performing the action and broadcasting it to the blockchain.

Screen Shot 2019-04-30 at 12.26.09 pm.jpg

  • What feature(s) did you add?
    Describe briefly and add screenshots/recordings if applicable.
  • How did you implement it/them?
    Link to relevant lines in the code on GitHub and explain briefly what you added/changed.

Code changes

The code changes are quite simple but adds value to the Witnesses page.

Screen Shot 2019-04-30 at 1.44.19 pm.jpg
https://github.com/steemit/wallet/pull/41/files

GitHub Account

Paste here the full url to your GitHub account. E.g. https://github.com/quochuy

Sort:  

Thank you for your contribution. I agree that even this looks simple code changes, but it enhances the User Experiences overall. I am a bit concern that the message prompt you add there could be extracted to some JSON files which can be localised - I understand probably steemit hasn't done such though.

Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.

To view those questions and the relevant answers related to your post, click here.


Need help? Chat with us on Discord.

[utopian-moderator]

Thank you for reviewing. I agree localisation is something that will add value to Steemit

Posted using Partiko iOS

Thank you for your review, @justyy! Keep up the good work!

Hey, @quochuy!

Thanks for contributing on Utopian.
We’re already looking forward to your next contribution!

Get higher incentives and support Utopian.io!
Simply set @utopian.pay as a 5% (or higher) payout beneficiary on your contribution post (via SteemPlus or Steeditor).

Want to chat? Join us on Discord https://discord.gg/h52nFrV.

Vote for Utopian Witness!

Hi @quochuy!

Your post was upvoted by @steem-ua, new Steem dApp, using UserAuthority for algorithmic post curation!
Your post is eligible for our upvote, thanks to our collaboration with @utopian-io!
Feel free to join our @steem-ua Discord server

Hi, @quochuy!

You just got a 0.24% upvote from SteemPlus!
To get higher upvotes, earn more SteemPlus Points (SPP). On your Steemit wallet, check your SPP balance and click on "How to earn SPP?" to find out all the ways to earn.
If you're not using SteemPlus yet, please check our last posts in here to see the many ways in which SteemPlus can improve your Steem experience on Steemit and Busy.


Congratulations @quochuy!
You raised your level and are now a Dolphin!

Vote for @Steemitboard as a witness to get one more award and increased upvotes!

Coin Marketplace

STEEM 0.29
TRX 0.12
JST 0.035
BTC 65869.37
ETH 3414.18
USDT 1.00
SBD 4.58