Proposal Progress: Fixing test_block_log

Thanks for all the supporters for Proposal: Fixing Steemd Build Dependencies in the Latest OS

Progress Update

PR: https://github.com/steemit/steem/pull/3704

Currently, the test_block_log will crash because of an intended failure:

auto r3 = log.read_block( r2.second );
idump( (r3) );

Previously:

auto r1 = log.read_block(0);       // ✅ OK, returns b1, next offset = 248
auto r2 = log.read_block(r1.second); // ✅ OK, returns b2, next offset = EOF

At this point, r2.second points to the end of the file, i.e., there’s no next block.

image

This is intended behaviour, but the error (exit) code is non-zero which is misleading. This PR addresses this issue and return 0 when tests pass.

Tested

image

Steem to the Moon🚀!

Support me, thank you!

Why you should vote me? My contributions
Please vote me as a witness or set me as a proxy via https://steemitwallet.com/~witnesses

image.png

Coin Marketplace

STEEM 0.08
TRX 0.28
JST 0.035
BTC 101414.57
ETH 3321.86
USDT 1.00
SBD 0.50