SteemPlus [2.18.1] Boost Button doesn't handle comment permalinks and opens empty container
Project Information
Repository: https://github.com/stoodkev/SteemPlus/
Project Name: SteemPlus
Publisher: @stoodkev
Expected behaviour
In the event that I click on the Boost button option with SteemPlus from a comment on busy.org I should either be presented with one of the following when I try to "boost":
- I should not be able to click on the boost button if the permalink (comments) is not valid for boosting.
- I should remove/ignore the comment details from the permalink in the event they're present.
- Upon click of the boost button I should be given an indication that the boost button cannot be used to boost comments and asked if I would like to boost the main post.
- In the event the chosen boosting provider supports comment voting I should be able to boost the comment.
Actual Behaviour
When I try to boost a post which is a comment (as indicated by permalink) the boost pop up fails to load the boost chart and it's contents and simply shows an empty white container.
Pre-Requisites
- The account which you're using to test should have made at least one comment on the Steem blockchain.
Steps to reproduce
- From a fresh install download SteemPlus here
- Complete the on-boarding flow and sign in via steemconnect
- You will be redirected to Steemit.com (if you're already on the site, refresh to ensure the steemplus extension is working as expected)
- Go to busy.org and sign in with your account.
- Go to settings ensure you have “Boost Button” enabled within the settings pop up for SteemPlus, this should be enabled by default.
- Within busy, go to comments and click on any comment within the list.
- Once redirected to the comment, click on the 3 dot menu shown in the bottom bar. Note: If you have the floating post bar enabled you may need to scroll before it's visible, at the moment it appears below the posting bar. Please see video for further indication surrounding the issue I mention here.
- Once this menu is launched, click on boost.
- Note that the boost modal doesn't load and blank container is provided.
Environment
- Browser: Google Chrome (Version 65.0.3325.162 (Official Build) (64-bit))
- Device: MacBook Pro (Retina, 15-inch, Late 2013)
- Operating system: MacOS HighSierra Version 10.13
- Application Version of Testing: 2.18.1 (Updated: July 18, 2018)
Recording of issue
The following video shows this issue in more detail:
Error
The following errors are provided within the console upon the error occurring:
Proof of work
My GitHub account: https://github.com/tobias-g1
This issue has been reported, acknowledged and fixed, you can find out more information here: https://github.com/stoodkev/SteemPlus/issues/126
Hello!
Thank you for the report to SteemPlus that has been acknowledged and resolved. While the formatting, video and all the details you've included are really nice and clean, I found myself lost in the explanation at times due to a few errors in your English. I'm sure this is not something you can immediately improve but I think it'd be very valuable if you looked into improving your English skills!
Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.
To view those questions and the relevant answers related to your post, click here.
Need help? Write a ticket on https://support.utopian.io/.
Chat with us on Discord.
[utopian-moderator]
Cheers for the review. I took a look over and you're right, the actual and expected behaviour were horrible. That's what I get for not proofreading and writing a lot of issues in a single day. Kind of embarrassing as it's my first language hah. I'll proofread next time (y)
With the above in mind I can understand you gave one of the answers as the following "The title provided sufficient information, but the description of the steps to bug reproduction severely lacked in clarity." Was that due to what I mentioned or was there something actually wrong with the steps?
That was due to the mistakes in your English, which I also thought was your first language! That left me so confused! I later thought about it again when reviewing your other posts and wasn't exactly sure if this was the correct answer for the question, but decided to leave it be as I would need to adjust the formating, presentation & language question instead which would have a similar impact on your score.
Congratulations! Your post has been selected as a daily Steemit truffle! It is listed on rank 12 of all contributions awarded today. You can find the TOP DAILY TRUFFLE PICKS HERE.
I upvoted your contribution because to my mind your post is at least 11 SBD worth and should receive 81 votes. It's now up to the lovely Steemit community to make this come true.
I am
TrufflePig, an Artificial Intelligence Bot that helps minnows and content curators using Machine Learning. If you are curious how I select content, you can find an explanation here!Have a nice day and sincerely yours,
TrufflePigHey @tobias-g
Thanks for contributing on Utopian.
We’re already looking forward to your next contribution!
Want to chat? Join us on Discord https://discord.gg/h52nFrV.
Vote for Utopian Witness!