Thank you for your contribution.
Few thoughts :
1 - Its better to be consistent with the style like if you are using '===' for equals use it everywhere like https://github.com/bflanagin/EduSteem/blob/master/Mobile/Logic/OSAuth.js#L10
2 - The below code is almost repeating 3-4 times, so its better to create a function and call it and that's why it will make your code looks clean.
if (http.responseText === "100") {
console.log("Incorrect DevID")
} else if (http.responseText === "101") {
console.log("Incorrect AppID")
} else {
heart = http.responseText
}
3 - The line https://github.com/bflanagin/EduSteem/blob/master/Mobile/Logic/course.js#L10can lead to SQL Injection.
Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.
To view those questions and the relevant answers related to your post, click here.
Need help? Write a ticket on https://support.utopian.io/.
Chat with us on Discord.
[utopian-moderator]
Thank you for your review, @codingdefined!
So far this week you've reviewed 4 contributions. Keep up the good work!
1 legacy code before I read up on the need for the extra = to be added. I'll do a search for any lingering mis matches like that.
2 My plan is to convert most of the xmlhttprequest code to either a proper networking stack or web sockets. In a future release, and I agree that code is a little redundant.
3 I think we're going to sound like a broken record after a while, the data that could cause the injection isn't human accessible and scrubbed in other parts of the program. However, I have found a method that seems to work with Qt's SQL implementation and will start replacing the insecure code with a more secure version.
I'm never sure if you're a bot or not, but thanks for all the work you do for utopian.