You are viewing a single comment's thread from:

RE: Utopian Task Completion: Steem Editor

in #utopian-io7 years ago (edited)

Hi justyy,

Thanks for the feedback. Correct, built files were already being shipped in the package. I believe the reason for doing this is to allow the Git repository itself to be installable without needing Npm.

Chinese comments were a prior artefact, in some cases, they were not needed. The text at the top of the Webpack file was removed, as it is an entirely new file. Going from Webpack 2 to 4, the differences were so great I started new files from scratch and gradually ported loaders and config options.

Webpack configuration files should be mostly undocumented, as they're expressive and implicit already (following documented conventions). Only specific instances like chunk configuration and other complex things should be commented, I believe. Everyone has their personal preference.

The existing comment at the top was also too detailed. Git is intended to show you who and when a file was changed, so much of the prior information was redundant. Configuration files also do not fall under copyright, as they're not unique.

As per MIT licence requirements, a LICENSE file exists in the root of the repository with the licence in question. A comment with copyright notice is not a requirement under the MIT licence, it's one of the most "open" open source licences out there (I love it).

Thanks again. Nice thorough review. You're doing a great job for @utopian-io

Coin Marketplace

STEEM 0.09
TRX 0.31
JST 0.031
BTC 106601.18
ETH 3832.91
USDT 1.00
SBD 0.58