[1Ramp Alpha Web App] - Unable to render link in embedded link if https:// or http:// is not included within URL
Project Information
Repository: https://github.com/hapramp/alpha-web
Project Name: 1Ramp Alpha Web App
Publisher (if applicable): @singhpratyush
Expected behavior
If you don't include https:// within your embedded link when creating a new article a user should either be shown an error warning, it should automatically prepend https:// or https://. It should not render the 1ramp create a post page as a default link.
Actual Behaviour
If you enter a link without https:// or http:// it will not show the link that you added, instead it will show the 1ramp create a post page within the embedded link.
Steps to reproduce
- Go to https://alpha.1ramp.io/feed/
- Sign in using your Steem Account
- Click the floating menu option shown in the bottom right, select article
- Click the embedded link option shown in the editor
- Type in "www.google.co.uk"
- Note that the embedded link does not load www.google.co.uk and instead loads the 1ramp create post page.
- Repeat step 4 and type in https://www.google.co.uk
- Note that it loads correctly.
Additional Information
As you can see from the discussion there is a need for adjustments to be made to this feature, the current method is also likely to have issues surrounding X-Frame-Options as many sites will not allow their content to be rendered within an iFrame due to security reasons. The solution will be to provide a pre-defined list of allowed sites that can be used within the embeddable links option within the site menu.
Note: The solution was suggested by the project owner and not myself, I simply wanted to mention the other issues that will arise with the current implementation method.
Environment
- Browser: Google Chrome (Version 65.0.3325.162 (Official Build) (64-bit))
- Device: MacBook Pro (Retina, 15-inch, Late 2013)
- Operating system: MacOS HighSierra Version 10.13
Recording of Issue
The following issue can be seen in the view below:
GitHub Account
A link to my GitHub account can be found below:
The issue was submitted to the repository here:
Hi @tobias-g, thanks for submitting this report.
It appears the web app is plagued with some unusual behavior. A good thing you spotted this. To an end user - simply inputing a link in the format "linkname.com" should return the requested page. Most are not bothered with the workings of the url bar which is understandable, all they wanna see are the results.
It becomes an issue when you specifically seek A but get B. Its a great find.
The post title is exactly as it should be, with just enough information to give the PO a glimpse to what possibly went wrong.
I like how in very simple terms you identified the difference in behavior between what is expected and what is actually gotten. If as a user I type in "google.com", I want to see google not the "create post" page. I am just a user of technology, I don't care what led to the error, I just want google.
The steps you provided were clear as day and quite easy to walk through.
This report adds significant value to the open source community and is reflected in my scoring.
Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.
To view those questions and the relevant answers related to your post, click here.
Need help? Write a ticket on https://support.utopian.io/.
Chat with us on Discord.
[utopian-moderator]
Thank you for your review, @fego! Keep up the good work!
Hi, @tobias-g!
You just got a 2.46% upvote from SteemPlus!
To get higher upvotes, earn more SteemPlus Points (SPP). On your Steemit wallet, check your SPP balance and click on "How to earn SPP?" to find out all the ways to earn.
If you're not using SteemPlus yet, please check our last posts in here to see the many ways in which SteemPlus can improve your Steem experience on Steemit and Busy.
Hey, @tobias-g!
Thanks for contributing on Utopian.
We’re already looking forward to your next contribution!
Get higher incentives and support Utopian.io!
Simply set @utopian.pay as a 5% (or higher) payout beneficiary on your contribution post (via SteemPlus or Steeditor).
Want to chat? Join us on Discord https://discord.gg/h52nFrV.
Vote for Utopian Witness!