Smoke-Keychain Chrome Extension!

in utopian-io •  5 days ago

Repository

https://github.com/dunncreativess/steem-keychain

Bug Fixes

  1. Had to edit out some SBD stuff

  2. Switched Witness stuff to my Smoke.io witness

  3. https://github.com/DunnCreativeSS/steem-keychain/commit/87b211bf4b733655452aa2b48b4166931a81c685#diff-e84f1b43b56816e03fbbc5fc725ff34d

  4. https://github.com/DunnCreativeSS/steem-keychain/commit/be0d626e3bc4df30e7c1ee42a9c93c44a42ab30e

New Features

  1. Had to switch the RPC endpoints

  2. Also added a woocommerce extension to allow payments in Smoke using the smoke-keychain

  3. https://github.com/DunnCreativeSS/steem-keychain/commit/87b211bf4b733655452aa2b48b4166931a81c685#diff-2650fb3e14b7f42d68a8766269c54434

  4. https://github.com/DunnCreativeSS/steem-keychain/blob/master/woo-smoke.zip

New Projects

  • What is the project about?
    Ported steem-keychain to smoke-keychain although I didn't retitle the repo. It has all the functions of steem-keychain and additional security, allowing websites to interact with the plugin in order to achieve Smoke transactions browser-side
  • Technology Stack
    Chrome extension
  • Roadmap
    Clean up the UI]
  • How to contribute?
    Contact me on Steem @hodlorbust or Smoke.io @tradeitforweed or GitHub @dunncreativess

GitHub Account

https://github.com/dunncreativess

Authors get paid when people like you upvote their post.
If you enjoyed what you read here, create your account today and start earning FREE STEEM!
Sort Order:  

Hi, thanks for the contribution @hodlorbust. As I have mentioned in previous reviews it's not great to have all changes in one commit. In the commit you link there are 6,064 additions and 16,255 deletions. From your post it's completely unclear to me what part of these 6,064 additions you actually implemented recently and what is reused code from elsewhere. Because of this I feel like it's really difficult for me to review this accurately, so I will give you a chance to make it more clear to me. Once you have done so I will update this comment with the actual review.


After talking to you on Discord I sort of have a better idea of what was actually implemented. It would be great if you could make this abundantly clear for future contributions, as that will save both of us time in the long run.


Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.

To view those questions and the relevant answers related to your post, click here.


Need help? Write a ticket on https://support.utopian.io/.
Chat with us on Discord.
[utopian-moderator]

·

Thank you for your review, @amosbastian! Keep up the good work!

When you say you edited out some SBD stuff, does that mean that you removed some previously existing features for the Steem blockchain?

"I want to receive a payout from the @hodlorbust faucet!"

Hi @hodlorbust!

Your post was upvoted by @steem-ua, new Steem dApp, using UserAuthority for algorithmic post curation!
Your post is eligible for our upvote, thanks to our collaboration with @utopian-io!
Feel free to join our @steem-ua Discord server

Hey, @hodlorbust!

Thanks for contributing on Utopian.
We’re already looking forward to your next contribution!

Get higher incentives and support Utopian.io!
Simply set @utopian.pay as a 5% (or higher) payout beneficiary on your contribution post (via SteemPlus or Steeditor).

Want to chat? Join us on Discord https://discord.gg/h52nFrV.

Vote for Utopian Witness!