Weekly overview of the bug-hunting category- week 49, 2018

This is a report on the weekly contributions to the bug hunting category. The post contains basic stats like the number of contributions received by the category, an excerpt on new contributors if there are any and a detailed comparison of the week's output with previous weeks.

Previous Reports

• Weekly overview of the bug-hunting category- week 44, 2018
• Weekly overview of the bug-hunting category- week 45, 2018
• Weekly overview of the bug-hunting category- week 46, 2018
• Weekly overview of the bug-hunting category- week 47, 2018
• Weekly overview of the bug-hunting category- week 48, 2018

Bug hunting contributions summary

• Week 49: November 29th - December 6th
• 5 Contributions, 5 scored, 5 rewarded
• 1 new contributor, @blockchainstudio
• An average score of 74

At the time of writing this report, all the bugs received have been fixed by their respective POs.

The contribution

Contributor	URL	Project	Score
@blockchainstudio	why-sbd-print-rate-is-still-1-despite-the-haircut-bug-report-explanation-and-suggestions	steemit	70
@neupanedipen	busy-org-shows-incorrect-vote-worth	busy.org	55
@tobias-g	1ramp-alpha-web-app---some-profiles-dont-load-null-images-within-feed	1ramp	75
@tobias-g	1ramp-alpha-web-app---unable-to-submit-post-comment	1ramp	85
@tobias-g	1ramp-alpha-web-app---error-occurs-when-post-submitted-with-same-title-used-in-previous-post-permlink-characters	1ramp	85

@blockchainstudio, a first-time contributor to the category, he noticed the SBD print rate was still at 1%.

This bug is due to separate and inconsistent

calculations for current_median_history and sbd_print_rate.

The sbd_print_rate is calculated here
https://github.com/steemit/steem/blob/7ebe3f8bddf9e58c943618f55136db6330dd95a0/libraries/chain/database.cpp#L3761-L3783

The first problem is current_median_history is already haircut (which I don't recommend doing so in Expected behavior), so percent_sbd can never surpass 10%.

The second problem is due to the inflation between the time when current_median_history is calculated and the time when update_virtual_supply() (which updates sbd_print_rate) is called, percent_sbd is always strictly less than 10% just a bit.

He would go on to give these suggestions

• Use non-haircut value for current_median_history for consistency

  • All other real history values are non-haircut values, as you can see on https://api.steemjs.com/get_feed_history. This inconsistency can create lots of confusions, e.g., recent asset value error (steemit.com) / voting value error (busy.org which they still have)
  • Witnesses still need to report non-haircut prices, which again is very inconsistent and confusing. (https://steemd.com/witnesses)

• Introduce a new variable such as "haircut discount" and show the value on steemd and get_feed_history as well.

  • For instance, https://api.steemjs.com/get_feed_history should show "base": "0.328 SBD", "quote": "1.000 STEEM", "haircut": "0.796"
  • This makes the code much more readable and much less prone to bugs such as the current one.

This contribution was reviewed by @crokkon

@neupanedipen, a returning contributor to the category, he discovered an error in the vote worth that pops up when the upvote slider is used. This same error is reflected on the user's dashboard as well.

When I click on the upvote option in a post (with slider option for voting enabled), it shows very high vote worth which is not actually your vote worth.

This issue was later resolved by the POs in busy.org's latest update.

@tobias-g, a moderator in the category, he decided this week he'll get his hands dirty - purring the whitelist for projects plagued with bugs. 1Ramp would prove to be exceptionally buggy. 1Ramp, as described in its FAQ is a social media platform for creators. On 1Ramp, you can join communities of your interest (art, literature, photography, fashion, travel etc), write blogs, share photos, get feedback, and take inspiration by browsing through the work shared by other creators. The moderator found three bugs, detailed below:

• When visiting the profile for a steemit user, for example (https://alpha.1ramp.io/@tobias-g) the profile loads initially, but then a white screen is shown. The PO would fix this bug in this commit - https://github.com/hapramp/alpha-web/commit/7dc0afd5636bd7855b31c0aa39aeebef5fad4625

• When attempting to comment on a post, the comment is not submitted to the blockchain. The following error is shown within the console:

steemconnect.com/api/broadcast:1 

Failed to load resource: the server responded with a status of 500 ()

Within the response from SteemConnect the following error is provided:

{"error":"server_error","error_description":"permlink.size() > STEEM_MIN_PERMLINK_LENGTH && permlink.size() < STEEM_MAX_PERMLINK_LENGTH: Permlink is not a valid size."}

The following request payload was used in the above request:

{"operations":[["comment",{"parent_author":"","parent_permlink":"","auth

This issue was resolved by the PO in this pull request - https://github.com/hapramp/alpha-web/pull/80

• When a user attempts to submit a post with a title that has already been used previously, the application will throw an error. When you create a post with the same title the application prepends the current date & time to the permlink, however, the timestamp is causing an error upon submission to the blockchain via Steem Connect.
  Upon submitting the first post, the request payload is as follows:

{"operations":[["comment",{"parent_author":"","parent_permlink":"hapramp","author":"votezilla","permlink":"this-is-a-title","title":"this is a title","body":"<p>this is a body</p>\n\n  <div id=\"1ramp-footer\" />\n  <hr>\n  <center>\n  <h4>\n  <a href=\"https://1ramp.io\">\n  <img src=\"https://ipfs.busy.org/ipfs/QmTFN4mf55SRZkP8Ug7jXVP3sXAmH7sd35zMNwLFpgGqNU\"/>\n  </a>\n  <br>\n  See this post on <a href=\"https://play.google.com/store/apps/details?id=com.hapramp\">1Ramp Android</a> and <a href=\"https://alpha.1ramp.io/@votezilla/this-is-a-title\">Web</a>.\n  </h4>\n  </center>","json_metadata":"{\"tags\":[\"hapramp\",\"hapramp-design\",\"design\"],\"app\":\"hapramp/0.0.16\"}"}]]}

This created the following post: https://alpha.1ramp.io/@votezilla/this-is-a-title

When attempting to submit a post with the same title, the following errors are shown within the console:

Error 1

steemconnect.com/api/broadcast:1
Failed to load resource: the server responded with a status of 500 ()

Error 2

actions.js:86 [CREATE POST ERROR] Error: sc2-sdk error

at o.p [as _captureStackTrace] (bluebird.js:1068)

at o._resolveFromExecutor (bluebird.js:3246)

at new o (bluebird.js:2845)

at Object.createPost (steem.js:341)

at Object.<anonymous> (actions.js:69)

at r (runtime.js:62)

at Generator._invoke (runtime.js:296)

at Generator.e.(anonymous function) [as next] (https://alpha.1ramp.io/static/js/main.3492e6e4.js:1:1732164)

at r (main.3492e6e4.js:56758)

at main.3492e6e4.js:56758

Within the response from SteemConnect the following error is provided:

{"error":"server_error","error_description":"false: Invalid permlink character: T"}

The following request payload was used in the above request:

{"operations":[["comment",{"parent_author":"","parent_permlink":"hapramp","author":"votezilla","permlink":"20181202T132132047Z-this-is-a-title","title":"this is a title","body":"<p>this is a body</p>\n\n <div id=\"1ramp-footer\" />\n <hr>\n <center>\n <h4>\n <a href=\"https://1ramp.io\">\n <img src=\"https://ipfs.busy.org/ipfs/QmTFN4mf55SRZkP8Ug7jXVP3sXAmH7sd35zMNwLFpgGqNU\"/>\n </a>\n <br>\n See this post on <a href=\"https://play.google.com/store/apps/details?id=com.hapramp\">1Ramp Android</a> and <a href=\"https://alpha.1ramp.io/@votezilla/20181202T132132047Z-this-is-a-title\">Web</a>.\n </h4>\n </center>","json_metadata":"{\"tags\":[\"hapramp\",\"hapramp-design\",\"design\"],\"app\":\"hapramp/0.0.16\"}"}]]}

This post was resolved by the PO in this pull request - https://github.com/hapramp/alpha-web/pull/82.

The 3 contributions by tobias-g were reviewed and scored by @fego.

In summary, there were 5 contributions to the category this week and all were scored and rewarded and also in accordance with the Utopian review guidelines governing the category. There were no staff picks. There was a new contributor to the category this week, @blockchainstudio. Also, @neunpanedipen returned to bug hunting after a long break from the category, good to have you back :).

Hunter Totals and Average

@tobias-g joins @mightypanda who's been the most consistent of the hunters for weeks past, they both top the bug-hunters table with 3 finds each. @tobias-g is presently the hunter with the highest average reward score of 81.67, previously occupied by @stmdev at 80.

Weekly Average Score and number of Contributions

All contributions were scored and rewarded this week, hence the week's average score is 74. The average score of 74 is higher than week 48 and week 47's 0 and 65.17 respectively. It is the highest recorded average in 8 weeks. Compared to last week, this week the category received 4 contributions more. Note that in the calculation of the average, the zero scored contributions are not included.

Reports Reviewed By Reviewer

The 19 contributions received by the category in the past 8 weeks were assessed by 4 reviewers. Of the 19 contributions, 16 were rewarded.

• @sachincool have now reviewed 2 contributions (40, 40) with an average score of 40.
• @fego have reviewed 12 contributions (45.5, 72.5, 44.5, 80, 35.5, 80, 55, 75, 85, 85) with an average score of 65.8.
• @tobias-g have reviewed 4 contributions (37.5, 65, 70) with an average score of 57.5.
• @crokkon have reviewed 1 contribution, with an average score of 70.

Other items

In other updates, the category is currently discussing with @espoem possible ways to onboard project owners and bug-hunters alike. Plans are being put in place to further expand the whitelist to give the testers a much broader field to explore. Hopefully, the measures to achieving these objectives would be further addressed in the moderator's weekly meeting scheduled for Monday, 10th of December 2018.

For bug-hunters and open source enthusiasts looking to help open source projects, please take a look at our whitelist of projects that you can submit bug reports for:

https://docs.google.com/spreadsheets/d/1S7ayFTEy5CBMyeJvFRgq5JUjlqZxFjWAWhhrBL0GC60/edit#gid=1954068373

---

If you wish to have your open source projects added to our whitelist you can contact us on our help channel at our discord server. You can also leave your questions and comments below :)

---

Thanks

@fego