[Steem] [0.19.12] percent_steem_dollars value in the comment_options operation shows random results

in utopian-io •  3 months ago

Project Information

Repository: https://github.com/steemit/steem
Project Name: Steem
Affected version: 0.19.12 (AppBase)

Expected behavior

When querying the blockchain, the percent_steem_dollars in the comment_options should return an accurate value, usually it's 10000 (e.g. 100%).

Actual behavior

The returned value is random and could be higher than the maximum value of 10000, on AppBase RPC nodes.

How to reproduce

As an example, in block # 25220874, transaction_num 15 (https://steemd.com/tx/b36161d4ce03bf28f70ad0dad938587a2c0fb86e), the percent_steem_dollars value is 10000. Working properly with non-appbase RPC nodes:

curl -s -d '{"id":0,"jsonrpc":"2.0","method":"call","params":["condenser_api","get_block",[25220874]]}' https://rpc.steemviz.com | jq -r ".result.transactions[15]"
curl -s -d '{"id":0,"jsonrpc":"2.0","method":"call","params":["condenser_api","get_block",[25220874]]}' https://rpc.buildteam.io | jq -r ".result.transactions[15]"
curl -s -d '{"id":0,"jsonrpc":"2.0","method":"call","params":["condenser_api","get_block",[25220874]]}' https://gtg.steem.house:8090/ | jq -r ".result.transactions[15]"

(requires jq on linux, apt install jq)

percent_steem_dollars bug nonappbase.jpg

But on AppBase nodes, it's giving random results every time it's queried! Interestingly on api.steemit.com it gives one value only: 55832 (which is still wrong).

curl -s -d '{"id":0,"jsonrpc":"2.0","method":"call","params":["condenser_api","get_block",[25220874]]}' https://api.steemit.com | jq -r ".result.transactions[15]"
curl -s -d '{"id":0,"jsonrpc":"2.0","method":"call","params":["condenser_api","get_block",[25220874]]}' https://appbasetest.timcliff.com | jq -r ".result.transactions[15]"
curl -s -d '{"id":0,"jsonrpc":"2.0","method":"call","params":["condenser_api","get_block",[25220874]]}' https://appbase.buildteam.io | jq -r ".result.transactions[15]"

percent_steem_dollars bug appbase.jpg

Proof of work done

Github account: https://github.com/Jolly-Pirate
Github issue: #2807

Authors get paid when people like you upvote their post.
If you enjoyed what you read here, create your account today and start earning FREE STEEM!
Sort Order:  

Hi @drakos, thanks for making this contribution

Going through the ticket you opened in github, I see a developer has been assigned to it. Hopefully a fix is in the works.

My feedback:

  1. Though the title provides the sufficient information, it is missing a tiny bit of detail, the release version. The format should be ([Product Name] [Product Version] – Succinct description of the bug).

  2. The expected and actual behaviors were properly explained. Anyone reading can easily spot the discrepancy in the behavior.

  3. Your "How to reproduce" though easy to follow ought to be more detailed.

  4. Do you know that analyzing what possibly led to the error and then proposing a possible fix greatly increases your review score? You should try including these in your next report ;).

Thanks again for the contribution. I look forward to your next report.

Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.

To view those questions and the relevant answers related to your post, click here.

Need help? Write a ticket on https://support.utopian.io/.
Chat with us on Discord.


Updated the title.


Thank you for your review, @fego!

So far this week you've reviewed 5 contributions. Keep up the good work!

Hey @drakos
Thanks for contributing on Utopian.
We’re already looking forward to your next contribution!

Want to chat? Join us on Discord https://discord.gg/h52nFrV.

Vote for Utopian Witness!

we love @drakos all the way



Hi @drakos! We are @steem-ua, a new Steem dApp, computing UserAuthority for all accounts on Steem. We are currently in test modus upvoting quality Utopian-io contributions! Nice work!

great, I an not perfect with all this, but looks great! Like an artwork!))

Thank you for the interesting post!
(Would be great if you take a look of my latest drawing;)

Hello @drakos, I'm glad to hear from you!😍 Today I am not reading an incredible poetry😊, but I read your projects, which is very good for the community since you help a lot. 👏👏👏👏