You are viewing a single comment's thread from:
RE: Steem Messenger V0.0.6 : Deep dive in the cryptography updates
Hi, the guidance says:
To be considered for potential reward, Bug Fixes and New Features should be submitted via Pull Requests. The Pull Request should have been merged within the past 14 days.
We have been working on the code for quite some time and we finish the new version now. From the rules, it is the date of the pull request that is relevant, not the commits. I mean we are two working on this projects and the work from the main developper (and project owner) got accepted in utopian: https://steemit.com/utopian-io/@kingswisdom/steem-messenger-v0-0-5-safestorage-safesocket-last-update-before-release-and-many-more.
Yes, I can see that, but it is @kingswisdom who opened up the PR (and he did most of the contribution as far as I can see from the list) and merged it. As you said, the main developer has a post accepted already.
He has a post for his work and I am making mine for my work.
Following what you cite, most of his commits should not get rewarded because there are way older. I now have a developer access to the repo so for us it did not make a difference who open/close the request since we have been working on the same branch.
And please, don't evaluate my work in term of number of commits compare to @kingswisdom. I focus on security and will always have a less quantitative impact on the source code.
I have NOT yet evalulated your work yet but I am just saying that from the number of commits. What I was saying is that it is @kingswisdom who opened up the PR - so I am not sure if this is eligible if you want to make a post on it. Will let you know after I get the opinions from the CM.