SteemPlus [2.18.1] Mentions Tabs doesn't provide feedback of selected tab following tab click on busy.org, all posts that are shown in the mentions tab give an indication that you have voted on them and Blog histogram posts perform no action on click

Project Information

Repository: https://github.com/stoodkev/SteemPlus/
Project Name: SteemPlus
Publisher: @stoodkev

The following contribution contains three smaller issues found on SteemPlus, these include:

1. Mentions Tabs doesn't provide feedback of selected tab following tab click on busy.org
2. All posts that are shown in the mentions tab give an indication that you have voted on them on busy.org
3. Blog histogram posts appear clickable although no action upon occurs on click of tags, author or post title

Issue 1: Mentions Tabs doesn't provide feedback of selected tab following tab click on busy.org

Expected behaviour

The tab which you're selecting on SteemPlus should be indicated by having the background colour set a dark blue.

Actual Behaviour

Although the when the tabs are loaded on the mentions page theres a dark blue background on the selected tab, upon first click of another tab another tab, the dark blue background disappears and you have no visual indication of the tab you're currently viewing.

Steps to reproduce

1. From a fresh install download SteemPlus here
2. Complete the on-boarding flow and sign in via steemconnect
3. You will be redirected to Steemit.com (if you're already on the site, refresh to ensure the steemplus extension is working as expected)
4. Go to busy.org and sign in with your account.
5. Go to settings ensure you have “Mentions Tab” enabled within the settings shown in extensions pop up window, this should be enabled by default.
6. Using the steem plus drop down within your profile, select "Mentions".
7. When it loads, take note that post's loads with a blue background.
8. Click on comments.
9. Note that there is no indication of the selected tab.

Environment

• Browser: Google Chrome (Version 65.0.3325.162 (Official Build) (64-bit))
• Device: MacBook Pro (Retina, 15-inch, Late 2013)
• Operating system: MacOS HighSierra Version 10.13
• Application Version of Testing: 2.18.1 (Updated: July 18, 2018)

Recording of issue

The following video shows this issue in more detail:

Proof of work

The following issue has been reported, acknowledged and resolved. You can find a link to the issue below:

https://github.com/stoodkev/SteemPlus/issues/135

Issue 2: All posts that are shown in the mentions tab give an indication that you have voted on them on busy.org

Expected behaviour

The upvote button should only show as voted on posts which I have voted on within the mentions tab on SteemPlus.

Actual Behaviour

All posts shown within mentions

Steps to reproduce

1. From a fresh install download SteemPlus here
2. Complete the on-boarding flow and sign in via steemconnect
3. You will be redirected to Steemit.com (if you're already on the site, refresh to ensure the steemplus extension is working as expected)
4. Go to busy.org and sign in with your account.
5. Go to settings ensure you have “Mentions Tab” enabled within the settings shown in extensions pop up window, this should be enabled by default.
6. Using the steem plus drop down within your profile, select "Mentions".
7. Look at the post's provided within the list and note that all posts provided an indication that you have voted on them. Click on one of the posts to confirm that you haven't voted on it.
8. Repeat 7 until you find a post which you haven't vote.

Environment

• Browser: Google Chrome (Version 65.0.3325.162 (Official Build) (64-bit))
• Device: MacBook Pro (Retina, 15-inch, Late 2013)
• Operating system: MacOS HighSierra Version 10.13
• Application Version of Testing: 2.18.1 (Updated: July 18, 2018)

Recording of issue

The following video shows this issue in more detail:

Proof of work

The following issue has been reported, acknowledged and resolved. You can find a link to the issue below:

https://github.com/stoodkev/SteemPlus/issues/136

Issue 3: Blog histogram posts appear clickable although no action upon occurs on click of tags, author or post title

Expected behaviour

The posts which appear within the blog histogram should be clickable and upon click a user should be taken to the post they clicked on.

Actual Behaviour

Although their is an indication that the posts are clickable with cursor: pointer, upon click no action occurs.

This includes when you click on tags, author, post header, comments.

Pre-requisite

1. The account which you use to test on should have at least one post made on the Steem blockchain.

Steps to reproduce

1. From a fresh install download SteemPlus here
2. Complete the on-boarding flow and sign in via steemconnect
3. You will be redirected to Steemit.com (if you're already on the site, refresh to ensure the steemplus extension is working as expected)
4. Go to settings ensure you have “Blog Histogram” enabled within the settings shown in extensions pop up window, this is not enabled by default.
5. Go to your blog and wait for the blog histogram to load.
6. Click on any day where you have had any activity.
7. A popup should appear which shows the posts which were made on that day.
8. Click on any of these posts, click on the title, tags and author and note that not action occurs.

Environment

• Browser: Google Chrome (Version 65.0.3325.162 (Official Build) (64-bit))
• Device: MacBook Pro (Retina, 15-inch, Late 2013)
• Operating system: MacOS HighSierra Version 10.13
• Application Version of Testing: 2.18.1 (Updated: July 18, 2018)

Recording of issue

The following video shows this issue in more detail:

Error

The following error is returned in the console:

utils.js:539 Uncaught TypeError: Cannot read property 'onPostClick' of null
    at openPost (utils.js:539)
    at HTMLAnchorElement.<anonymous> (utils.js:552)
    at HTMLAnchorElement.dispatch (jquery.js:3)
    at HTMLAnchorElement.q.handle (jquery.js:3)
    

Proof of work

The following issue has been reported, acknowledged and resolved. You can find a link to the issue below:

https://github.com/stoodkev/SteemPlus/issues/132

My GitHub Account

My GitHub account: https://github.com/tobias-g1