SteemPlus - [2.17.5] - boost pop up covered by post overlay on busy.org


Project Information

Repository: https://github.com/stoodkev/SteemPlus/
Project Name: SteemPlus
Publisher: @stoodkev

Expected behavior

The boost pop up window should appear above the post you wish to boost when the boost button is triggered. This should provide the user with a clear indication that the boost button is working as expected and thus enable them to boost the post.

Actual behaviour

When you press the boost button when viewing a post which appears as an overlay the boost button pop up window will appear below the post overlay. This is due to the z-index of the pop-up window being less than the post overlay.

How to reproduce

1. From a fresh install download SteemPlus here
2. Complete the on-boarding flow and sign in via steemconnect
3. You will be redirected to Steemit.com (if you're already on the site, refresh to ensure the steemplus extension is working as expected)
4. Go to busy.org and sign in with your account.
5. Go to settings ensure you have “Boost Button” enabled within the settings shown in extensions pop up window, this should be enabled by default.
6. Go to the news feed and click on any post. The post should open in an overlay the new feed.
7. Press the menu for this post, this is shown by the three vertical dots.
8. Click on the boost option which is shown at the bottom of the options.
9. The pop up for the boost options will appear underneath the post, this can be confirmed by closing the post which we originally opened.

Recording of issue

The following video shows the issue in more detail:

Environment

• Browser: Google Chrome (Version 65.0.3325.162 (Official Build) (64-bit))

• Device: MacBook Pro (Retina, 15-inch, Late 2013)

• Operating system: MacOS HighSierra Version 10.13

• Application Version of Testing: Version: 2.17.5 (Updated: June 22, 2018)

Note: This was originally tested on version 2.17.4 and I have retested on version 2.17.5 and the same issue occurs, with the same behavior so no further edits need to be made to this contribution.

Issue Resolution

This issue can be resolved by adjusting .modal-busy in boost_button.css from:

to the following:

The only adjustment made here is to the z-index from 1 to 10000. 10000 may not be needed, but I believe due to the circumstances when this pop up is shown this shouldn't cause an issue in other areas of the application.

You can see this being resolved by the suggested in the following video:

Note: I didn't submit a pull request as overall this is a very very small change and can easily be adjusted by the PO in prior to the next release.

Pull Request (Update: 26th June 2018)

Following this post, this issue has now been acknowledged by the developer and I have sent a pull request which has been merged, you can find a link to the pull request below:

https://github.com/stoodkev/SteemPlus/pull/112

Proof of work

My GitHub account: https://github.com/tobias-g1
The issue has been reported here: https://github.com/stoodkev/SteemPlus/issues/108