Steemit Condenser and Wallet bug fixes

View this post on Hive: Steemit Condenser and Wallet bug fixes

---

Repositories

https://github.com/steemit/condenser
https://github.com/steemit/wallet

Bug Fixes

There is a mistake about translation. #27 by Steem Witness @ayogom
The Korean translation was fixed in Fix Korean translation (#48)

Comment layers are not visible enough #3195 by Steem Witness @therealwolf
There have been few discussion about the new layout I've proposed which lead to a fix of the mobile stylesheet in Comment separation - Mobile layout #3408.

Apart from fixing the layout on mobile views, I've also reduced the left margin from 20px to 10px which was implemented mainly to make the comment hierachy more visible but since the new proposed layout adds a border around comments and is adding vertical lines to hilight replies to comments, that margin can be reduced to offer more space for rendering the nested comments.

Unable to cancel a reply on mobile (Brave) #3362 by Steem Witness @pjau

When you try to reply to a post or comment, the cancel button doesn't work at all, the textarea or post/cancel buttons won't disappear. I even tried multiples, none of them would close.

This seems to work fine on desktop using the Brave browser. But on the mobile version it doesn't work at all, even when I turn the shields off. I have also tried in Chrome but it seems to work fine for that on desktop and mobile. Which is strange because Brave is chromium.
Update, it was because I was logged out. When logged out it gives you the option to reply still. I logged out of chrome too and it doesn't work there either.

The fix was to simply not display the reply link when the user is not loggedin: Only show reply link to logged in users #3369

Content near top of screen is sometimes obscured #3281 by Jonathan Porta

This issue described when an ad banner is loaded into the header, the top of the article is being partially hidden by the header bar. Most of the time is because the ad is coming from a third-party service which has not yet sent back a response when the height of the header bar is being calculated. There have been multiple fix proposals submitted by various developers. Mine was to Replace 'slotRenderEnded' with 'impressionViewable' #3377 which got picked into a hybrid solution into another PR Fix header covering content #3404

From Doubleclick documentations https://developers.google.com/doubleclick-gpt/reference:
googletag.events.SlotRenderEndedEvent

This event is fired when the creative code is injected into a slot. This event will occur before the creative's resources are fetched, so the creative may not be visible yet.

googletag.events.ImpressionViewableEvent

This event is fired when an impression becomes viewable, according to the Active View criteria.

This made sense to use the impressionViewable event as that is when you can get the dimensions of the ad banner in order to calculate the height of the page's header bar.

Tables sometimes break words at every single letter #3373 by yours truly 😎

Because I regularly posts stats for various communities, I often encountered when a table header title is being truncated one letter per line as per the screenshot above. In modern HTML design, tables are evil because they don't adapt well on smaller screens. But in bloggin platforms like Steemit, it's difficult to use anything else than tables unless you use images...

The fix was a simple CSS change:

GitHub Account

https://github.com/quochuy