It's always great to see you supporting all kinds of projects with Python packages. I've personally not really checked out STEEM ENGINE, but I saw that a lot of people were very excited about it, so I'm curious to see where it goes. I'm also always very interested in checking out the code itself, as you are a great developer and I think other Python developers can learn a lot from you.
Saying this, there's still some feedback I'd like to give:
There are a lot of unused imports floating around multiple files. For example, in rpc.py you never use time, threading etc.
Using {} or [] as a default value isn't best practice: "this 'default' array gets created as a persistent object, and every invocation of my_method that doesn't specify an extras param will be using that same list object—any changes to it will persist and be carried to every other invocation!".
In wallet.py in the function change_account() you don't actually use the check_account variable - not sure if you just missed this or something is wrong there.
Great docstrings which make it very clear what the functions do. Adding the examples is a nice touch as well!
Imo some variable names like h and c could be improved (and some variables are camelCase, while others snake_case), but other than that everything is very readable.
Would recommend using pytest over unittest as it's imo better.
Good update with a lot of work. It's always a pleasure seeing your posts, so I can't wait to see future updates!
Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.
To view those questions and the relevant answers related to your post, click here.
$rewarding 30% 13min
Thanks for the review.
I check if the given account is an existing steem user name in change_account(). I do not need the account object, so it is not further used. I think I can just remove the left side (check_account).
Your post was upvoted by @steem-ua, new Steem dApp, using UserAuthority for algorithmic post curation!
Your post is eligible for our upvote, thanks to our collaboration with @utopian-io! Feel free to join our @steem-ua Discord server
Thanks for contributing on Utopian.
We’re already looking forward to your next contribution!
Get higher incentives and support Utopian.io!
Simply set @utopian.pay as a 5% (or higher) payout beneficiary on your contribution post (via SteemPlus or Steeditor).
Seems like the Steem-Engine team itself should be doing this kind of work and more... but glad you stepped in to cover them on this. I just hope they're committed to their project and it's not just a get rich quick product. I have hope though.
You just got a 3.5% upvote from SteemPlus!
To get higher upvotes, earn more SteemPlus Points (SPP). On your Steemit wallet, check your SPP balance and click on "How to earn SPP?" to find out all the ways to earn.
If you're not using SteemPlus yet, please check our last posts in here to see the many ways in which SteemPlus can improve your Steem experience on Steemit and Busy.
Hallo Holger, hab mir gerade Steem Engine angeschaut und auch die DEX. Ich muss sagen, was ihr da geleistet habt, ist unglaublich und ihr könnt arg auf euch stolz sein. Ich wünschte richtig ich könnt auch Python coden, aber das würd sicher Jahre dauern. Egal, zum Glück gibts Leute wie euch, die das drauf haben. SUPER ARBEIT - bin immer noch sprachlos. Jedenfalls ein Gewinn für Steemit! DANKE
It's always great to see you supporting all kinds of projects with Python packages. I've personally not really checked out STEEM ENGINE, but I saw that a lot of people were very excited about it, so I'm curious to see where it goes. I'm also always very interested in checking out the code itself, as you are a great developer and I think other Python developers can learn a lot from you.
Saying this, there's still some feedback I'd like to give:
rpc.pyyou never usetime,threadingetc.{}or[]as a default value isn't best practice: "this 'default' array gets created as a persistent object, and every invocation ofmy_methodthat doesn't specify an extras param will be using that same list object—any changes to it will persist and be carried to every other invocation!".wallet.pyin the functionchange_account()you don't actually use thecheck_accountvariable - not sure if you just missed this or something is wrong there.handccould be improved (and some variables are camelCase, while others snake_case), but other than that everything is very readable.pytestoverunittestas it's imo better.Good update with a lot of work. It's always a pleasure seeing your posts, so I can't wait to see future updates!
Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.
To view those questions and the relevant answers related to your post, click here.
Need help? Chat with us on Discord.
[utopian-moderator]
$rewarding 30% 13min
Thanks for the review.
I check if the given account is an existing steem user name in
change_account(). I do not need the account object, so it is not further used. I think I can just remove the left side (check_account).I will use your suggestions for my next update.
Thank you for your review, @amosbastian! Keep up the good work!
Fantastic. Can this be used to create automated sell orders that track a fixed $US price as Steem moves?
Posted using Partiko iOS
Yes, that would be possible with version 0.2.0.
Now someone just needs to make a JS version of it.
Congratulations @holger80! You have completed the following achievement on the Steem blockchain and have been rewarded with new badge(s) :
Click here to view your Board
If you no longer want to receive notifications, reply to this comment with the word
STOPTo support your work, I also upvoted your post!
Vote for @Steemitboard as a witness and get one more award and increased upvotes!
Hi @holger80!
Your post was upvoted by @steem-ua, new Steem dApp, using UserAuthority for algorithmic post curation!
Your post is eligible for our upvote, thanks to our collaboration with @utopian-io!
Feel free to join our @steem-ua Discord server
Hey, @holger80!
Thanks for contributing on Utopian.
We’re already looking forward to your next contribution!
Get higher incentives and support Utopian.io!
Simply set @utopian.pay as a 5% (or higher) payout beneficiary on your contribution post (via SteemPlus or Steeditor).
Want to chat? Join us on Discord https://discord.gg/h52nFrV.
Vote for Utopian Witness!
Seems like the Steem-Engine team itself should be doing this kind of work and more... but glad you stepped in to cover them on this. I just hope they're committed to their project and it's not just a get rich quick product. I have hope though.
Hi, @holger80!
You just got a 3.5% upvote from SteemPlus!
To get higher upvotes, earn more SteemPlus Points (SPP). On your Steemit wallet, check your SPP balance and click on "How to earn SPP?" to find out all the ways to earn.
If you're not using SteemPlus yet, please check our last posts in here to see the many ways in which SteemPlus can improve your Steem experience on Steemit and Busy.
This post has been included in the latest edition of SoS Daily News - a digest of all the latest news on the Steem blockchain.
Hallo Holger, hab mir gerade Steem Engine angeschaut und auch die DEX. Ich muss sagen, was ihr da geleistet habt, ist unglaublich und ihr könnt arg auf euch stolz sein. Ich wünschte richtig ich könnt auch Python coden, aber das würd sicher Jahre dauern. Egal, zum Glück gibts Leute wie euch, die das drauf haben. SUPER ARBEIT - bin immer noch sprachlos. Jedenfalls ein Gewinn für Steemit! DANKE