[Busy] incorrect vote value for users powering down
Project Information
- Repository: https://github.com/busyorg/busy
- Project Name: Busy
I reported an issue and made a fix and pull request.
Issue: https://github.com/busyorg/busy/issues/2141
PR: https://github.com/busyorg/busy/pull/2143
Expected behavior
The vote value should be shown correctly for users powering down.
Actual behavior
The vote value doesn't take power down into account. Since full power down takes 13 weeks, this may not be that significant in the beginning, but as time goes by, the difference is getting bigger and bigger, as shown in the example below.
I analyzed the code, and this is due to the wrong calculation of the total share for a user powering down. I made a fix and pull request.
How to reproduce
Pick any user powering down and check the vote value. A user who is almost finishing entire power down is easy to check, since the difference can be quite large, as you can see in the Recording Of The Bug section.
For instance, @ned is a good example, who is powering down for 11 weeks already.
https://busy.org/@ned
Compare this with https://steempeak.com/@ned
- Browser/App version: Any
- Operating system: Any
Recording Of The Bug
Busy doesn't reflect power-down (vote value is almost twice than the true value, next week it'll be more than twice unless this user doesn't stop powering down.)
Steempeak, for instance, shows the correct vote value
Just in case, here is the proof that Busy's vote value is wrong: Ned made an 1% upvote a few hours ago, and it's value is $0.03 (not $0.06~7).
GitHub Account
https://github.com/economicstudio
Issue: https://github.com/busyorg/busy/issues/2141
PR: https://github.com/busyorg/busy/pull/2143
Hi @blockchainstudio, thanks for the contribution.
I was able to observe this same behavior using ned's profile as you did. The value of the voting power like you pointed out, is not consistent with the reduction in steem power caused by the power down.
As with your previous reports, I see you already fixed the bug and made a pull request to that effect, which is very good. Do you know that waiting for the PO to first acknowledge the bug will also score you points in the review?
I see you had to wait 5 days after fixing the issue before making a utopian post. Well, sometimes the POs are just so busy, no pun intended ;)
My feedback:
Apart from that, its a good find. The steps to reproduction were easy enough to follow.
I look forward to your next report. Happy New Year :)
Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.
To view those questions and the relevant answers related to your post, click here.
Need help? Write a ticket on https://support.utopian.io/.
Chat with us on Discord.
[utopian-moderator]
Thank you for your review, @fego! Keep up the good work!
Hi @fego, thank you for your review and humor :) Sure next time I'll include the version number, which I already did in my next post. Busy team seems inactive these days, so I just submitted before it's merged. Thanks!
Summary in Korean: 파워다운하고 있는 스파만큼은 보팅파워에 안들어가는데 busy가 이걸 반영하고 있지 못합니다. 이미 직접 고쳐서 github에 수정요청도 해둔 상태인데 merge되고 나면 리포트하려 기다렸는데 busy팀도 연말연시라 더더욱 일을 안하는 듯 하고 마침 네드가 아까 보팅도 한번해서 보팅가치가 적어도 $0으로 보이지는 않고 네드의 경우 파워다운 한지 꽤 오래되어(11/13) 보팅가치 차이가 꽤 큰 상황이라 마침 보여주기 적당한 시점인 듯하여 리포팅부터 올립니다. 버그 고친건 몇개 묶어서 dev로 낼때 써야겠네요.
busy 가 일을 안하네요. busy는 블록체인스튜디오님께 감사패라도 만들어 드려야 할듯 ㅋㅋ
열일하시네요
수고하십니다.
Hi @blockchainstudio!
Your post was upvoted by @steem-ua, new Steem dApp, using UserAuthority for algorithmic post curation!
Your post is eligible for our upvote, thanks to our collaboration with @utopian-io!
Feel free to join our @steem-ua Discord server
Hey, @blockchainstudio!
Thanks for contributing on Utopian.
We’re already looking forward to your next contribution!
Get higher incentives and support Utopian.io!
Simply set @utopian.pay as a 5% (or higher) payout beneficiary on your contribution post (via SteemPlus or Steeditor).
Want to chat? Join us on Discord https://discord.gg/h52nFrV.
Vote for Utopian Witness!